Added new vehicle action into MissionItem message template #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
reviewed
Apr 29, 2021
|
Nitpick on the doc comment, but otherwise it looks good to me! The next step now would be to generate the C++ code and implement that new action 😊. Note that we will not merge this PR until the C++ implementation is done, that's normal. But now you know that we seem to agree on the interface, and you can move on to the actual implementation 👍 |
JonasVautherin
force-pushed
the
feature-extension-mission-item
branch
from
7c4edac to
2e07888
Compare
JonasVautherin
requested changes
May 5, 2021
|
@rligocki sorry, it looks like we were too slow to merge this. Do you mind fixing the conflict. |
|
It should be fixed. Commit 48b5349 did this. |
|
@rligocki ok but this PR needs updating then, I think. |
JonasVautherin
force-pushed
the
feature-extension-mission-item
branch
from
48b5349 to
1229de4
Compare
JonasVautherin
force-pushed
the
feature-extension-mission-item
branch
from
1229de4 to
80a32ed
Compare
JonasVautherin
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue: mavlink/MAVSDK-Swift#198