Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left-side shader showing before first time-tag time. #157

Closed
andy840119 opened this issue Apr 27, 2022 · 4 comments
Closed

Fix left-side shader showing before first time-tag time. #157

andy840119 opened this issue Apr 27, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@andy840119
Copy link
Member

andy840119 commented Apr 27, 2022

image
Should not show the yellow area.
.
What's should be fixed:

  • write something like IHasExtraSize or IAffectRelativePosition to let KaraokeSpriteText able to adjust the position.'
  • Add this property to OutlineShader only. Maybe will added in the StepShader also(for able to sum the outline)
  • Not really sure is there any way to change the lyric sprite size? Or is there any way to change the draw size?

Also, should write a test scene:

  • Maybe named TestSceneKaraokeSpriteTextWithTimeTags
  • Show the lyric with single or multi outline.
  • Able to change the clock time.
  • Should prevent clear the expired transformers.
  • Able to adjust the scale.
@andy840119 andy840119 added the enhancement New feature or request label Apr 27, 2022
@andy840119
Copy link
Member Author

andy840119 commented Apr 27, 2022

Also, need to check how DrawSize calculated.
And should we able to change the ComputeScreenSpaceDrawQuad changed?

@andy840119
Copy link
Member Author

Might create two interfaces:

  • One is for calculating the masking position
  • Another one will affect the drawable size?

@andy840119
Copy link
Member Author

andy840119 commented Apr 29, 2022

Maybe should write a test scene with big karaoke text for checking the outline issue.
Maybe named TestSceneKaraokeSpriteTextWithPreciseTiming?

Have default test value:

This test scene will for three test case:

@andy840119
Copy link
Member Author

Tested and guess this issue has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant