Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not restrict time-tag should ordered by time and index. #158

Closed
andy840119 opened this issue Apr 27, 2022 · 2 comments
Closed

Not restrict time-tag should ordered by time and index. #158

andy840119 opened this issue Apr 27, 2022 · 2 comments
Labels
code quality enhancement New feature or request

Comments

@andy840119
Copy link
Member

Because should not be possible to let the lyric crash.
Also for supporting some cool effect(like reversing).
So there's no need to sort by time and index, should just need to sort by time. in the RefreshStateTransforms.
@andy840119 andy840119 added enhancement New feature or request code quality labels Apr 27, 2022
@andy840119
Copy link
Member Author

Maybe writing a test case for checking the reverse effect.
Will use the same test case in the #157.

@andy840119 andy840119 mentioned this issue Apr 29, 2022
Merged
@andy840119
Copy link
Member Author

Seems that karaoke sprite text already support reverse time-tag.
So write the test case only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andy840119