Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix left-side shader showing before first time-tag time. #177

Merged
merged 5 commits into from
May 4, 2022
Merged

Fix left-side shader showing before first time-tag time. #177

merged 5 commits into from
May 4, 2022

Conversation

andy840119
Copy link
Member

Guess it's time to close the #157

What's done in this PR:

  • Adjust getTextIndexPosition() in karaoke sprite text to get the more suitable transformer position.
  • Adjust initial width size.

Related to code-quality:

  • rename from front/back to left/right for better understanding.
  • should check text and time-tag state in the RefreshStateTransforms().

@andy840119 andy840119 added bug Something isn't working code quality labels May 4, 2022
@andy840119 andy840119 merged commit 7b14097 into karaoke-dev:master May 4, 2022
@andy840119 andy840119 deleted the fix-transformer-with-outline-shader-issue branch May 4, 2022 16:45
@andy840119 andy840119 mentioned this pull request May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working code quality size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119