Fix left-side shader showing before first time-tag time. #166

andy840119 · 2022-04-30T17:07:23Z

Fix issue #157.
Still have some issues need to be fixed, but guess should be OK enough to be merged.

What's done in this PR:

make the interface.
apply the interface and write the test case for it.
apply the outline size in the karaoke sprite text transforms.
now lyric sprite text will auto-calculate the draw size if change the shader or re-draw.

…draw size.

Should affect the padding in the masking container also. . Because it might this commit be complicated if implement here, so implemented in another PR.

andy840119 added 3 commits April 30, 2022 22:26

Add the interface for inherit if shader will affect the char size or …

ffd0279

…draw size.

apply the interface.

a9c7622

Add the test case and fix the compile error.

8952aed

pull-request-size bot added the size/L label Apr 30, 2022

andy840119 added the enhancement New feature or request label Apr 30, 2022

andy840119 added 3 commits May 1, 2022 22:14

Almost there.

c544141

Should affect the padding in the masking container also. . Because it might this commit be complicated if implement here, so implemented in another PR.

Adjust initial time in the test scene.

6e90dcc

Now it's able to calculate the draw quad by the shader.

ef7acee

andy840119 force-pushed the fix-outline-shader-issue branch from 3c317e1 to ef7acee Compare May 1, 2022 14:18

andy840119 merged commit 48173a3 into karaoke-dev:master May 1, 2022

andy840119 deleted the fix-outline-shader-issue branch May 1, 2022 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix left-side shader showing before first time-tag time. #166

Fix left-side shader showing before first time-tag time. #166

andy840119 commented Apr 30, 2022

Fix left-side shader showing before first time-tag time. #166

Fix left-side shader showing before first time-tag time. #166

Conversation

andy840119 commented Apr 30, 2022