Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should re-calculate the transforms if change the shader in the karaoke sprite text. #178

Closed
andy840119 opened this issue May 5, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@andy840119
Copy link
Member

Remain issue in the #157
Found in the karaoke-dev/karaoke#1293

Should re-calculate the transforms if change the shader in the karaoke sprite text.

@andy840119 andy840119 added the bug Something isn't working label May 5, 2022
@andy840119
Copy link
Member Author

andy840119 commented May 5, 2022

Should write test case to show if RefreshStateTransforms has been triggered.

Maybe it's able to add in the TestSceneKaraokeSpriteText.
Also, not really sure should let this shit to inherit the BackgroundGridTestScene and TestSceneLyricSpriteText. -> Note that BackgroundGridTestScene is for testing if shader affect the background.

@andy840119
Copy link
Member Author

Or should write a new test case to check the invalidate state?

@andy840119
Copy link
Member Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant