Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the romaji to the time-tag. #2004

Closed
andy840119 opened this issue May 12, 2023 · 7 comments
Closed

Move the romaji to the time-tag. #2004

andy840119 opened this issue May 12, 2023 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@andy840119
Copy link
Member

Not very sure about that but it will be useful to show the romaji-only lyric if we make every char has it's own romaji.

@andy840119 andy840119 added the enhancement New feature or request label May 12, 2023
@andy840119
Copy link
Member Author

andy840119 commented May 12, 2023

我又懶了,用一下中文好了

image
目前 romaji 的設計是歌詞的一小段會
而不是每一個字元都有對應的 romaji
如果有一天需要做出只會顯示 romaji 的歌詞,會有 time-tag 對不上的問題

Recorded in here:
https://karaoke-dev.notion.site/tomaji-text-tag-time-tag-8c351278062a470fa4449a9172b3ad02?pvs=4

@andy840119
Copy link
Member Author

另外,或許需要設計更好的 tool,去 combine and separate the romaji?

@andy840119
Copy link
Member Author

andy840119 commented May 23, 2023

Guess:

  1. Remove the romaji text class and add the romaji property into the time-tag.
  2. Add the RomajiContinuous property in the time-tag.

想法是一個 time-tag 通常對應一個音節,romaji也有類似的分段方式

@andy840119
Copy link
Member Author

andy840119 commented Jul 21, 2023

Remaining:

@andy840119
Copy link
Member Author

andy840119 commented Aug 4, 2023

Wait.
Note has Ruby text property.
Not very sure will have Romaji property in the note also? -> guess should be get from time-tag, or note should have time-tag index?

@andy840119
Copy link
Member Author

andy840119 commented Sep 29, 2023

Remaining part(editor):

Remaining part(drawable):

  • Support convert the ruby text from the time-tag into position text. -> not very sure what does this means?

Remaining part(object):

  • Remove the RomajiTag class.
  • Remove the ITextTag interface.
  • Remove any "text tag" wording in this project.
  • RomajiTag should be renamed to the Romaji or TimeTagRomaji

@andy840119
Copy link
Member Author

Most issue is implemented.

@andy840119 andy840119 added this to the 2024.0831 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant