New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the change handler for able to generate properties from lyric. #2134

Merged

andy840119 merged 4 commits into karaoke-dev:master from andy840119:separate-generate-logic

Sep 27, 2023

Member

andy840119 commented Sep 27, 2023

Preparation of #2004.

And note that this PR revert the #1958 and #1957.
Because one change handler does not actually means exactly one auto-generator.
So should be safe to collect all the generators into single change handler.

andy840119 added 4 commits

September 27, 2023 00:21


          Change handler interface should support the generate handler with enum.

3d519c8


          It's time to collect all generators into same change handler.

5d5e5dc

means revert the change in the karaoke-dev#1958.


          Fix the api broken.

2b3b6df


          Remove un-need change handler.

6f1ded2

andy840119 added code quality editor labels

andy840119 added this to the 2023.1010 milestone

pull-request-size bot added the size/XXL label

andy840119 added the Revert label

andy840119 merged commit 5c96bef into karaoke-dev:master

andy840119 deleted the separate-generate-logic branch

September 27, 2023 13:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality editor Revert size/XXL