Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add romaji text into time tag. #2070

Merged
merged 5 commits into from
Jul 16, 2023
Merged

Add romaji text into time tag. #2070

merged 5 commits into from
Jul 16, 2023

Conversation

andy840119
Copy link
Member

First implementation of #2004.
The final goal is remove the RomajiTag in this project.

@andy840119
Move all version bindable into the bindable category because it's upd…
edaf81e 
…ate by the the method in the bindable category.
@andy840119
Add new property into the time-tag.
168825c
@andy840119
Change the comment wording.
ad2c137
@andy840119
Add different changed type.
1ca70d1 
[why]
should not trigger lyric redrew just by change the time-tag time.
@andy840119
Should have time-tags romaji version in the lyric.
51859f5 
Also, rename from `TimeTagsVersion` into `TimeTagsTimingVersion`.
@andy840119 andy840119 added the encoder/decoder About beatmap format decode/encoder label Jul 16, 2023
@andy840119 andy840119 added this to the 2023.0808 milestone Jul 16, 2023
@andy840119 andy840119 merged commit e0ab86c into karaoke-dev:master Jul 16, 2023
@andy840119 andy840119 deleted the add-text-into-time-tag branch July 16, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
encoder/decoder About beatmap format decode/encoder size/L
Projects
None yet
Milestone
2023.0808
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119