Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite romaji edit mode. #2136

Merged
merged 13 commits into from
Sep 29, 2023

Conversation

andy840119
Copy link
Member

Implement editor part of #2004.
Should edit the property from the time-tag, not the romaji class.

@andy840119 andy840119 added the LyricMaker Implement lyric maker part into karaoke ruleset. label Sep 29, 2023
@andy840119 andy840119 added this to the 2023.1010 milestone Sep 29, 2023
@andy840119 andy840119 merged commit 16f4592 into karaoke-dev:master Sep 29, 2023
1 check passed
@andy840119 andy840119 deleted the rewrite-romaji-edit-mode branch September 29, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LyricMaker Implement lyric maker part into karaoke ruleset. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant