Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the auto-generate logic in the LyricAutoGenerateChangeHandler. #1957

Closed
andy840119 opened this issue Apr 24, 2023 · 3 comments
Closed
Labels
code quality Improve code quality.
Milestone

Comments

@andy840119
Copy link
Member

I think it might not be a good way to collect all the generators into single change handler.

Guess should remove the LyricAutoGenerateChangeHandler eventually.

@andy840119 andy840119 added the code quality Improve code quality. label Apr 24, 2023
@andy840119
Copy link
Member Author

I think AutoGenerateSubsection should include the generator inherit the IAutoGenerateChangeHandler?
But it will not able to call the change handler if inherit other kind of IAutoGenerateChangeHandler (e.g. IAutoGenerateChangeHandler<T>)

Need more think about this.

@andy840119
Copy link
Member Author

Implemented, nice.

@andy840119
Copy link
Member Author

It might not be a good idea if one property has more than 2 generators.

In #2004, time-tags change handler has 2 generator

  • generate the time-tags.
  • generate the romaji inside the time-tags.

Guess should be better to collect all generators again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve code quality.
Projects
None yet
Development

No branches or pull requests

1 participant