feat: tup-414 help users "View all …" #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another PR may require this value to change further: #312
Also, do so via— NEWS_DASHBOARD_DISPLAY_LIMIT —to mimic clarity of—TICKETS_DASHBOARD_DISPLAY_LIMIT
Also, do so via— PROJECTS_DASHBOARD_DISPLAY_LIMIT —to mimic clarity of—TICKETS_DASHBOARD_DISPLAY_LIMIT
wesleyboar
changed the title
This reverts commit 6d62c21. The alignment will not be an issue after new branch: enhance/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button
This was referenced Sep 8, 2023
Designers do not intend nor like big gap. It's been around since Portal. But it's been so difficult to fix… until `project-ticket-grid` came. I hadn't noticed the fix was possible until just now.
wesleyboar
commented
Sep 26, 2023
Comment on lines
-47
to
+48
| grid-template-rows: 1fr 1fr; | ||
| grid-template-areas: | ||
| grid-template-rows: auto 1fr; | ||
| grid-template-areas: |
There was a problem hiding this comment.
To fix an unrelated Dashboard layout bug that I am sneaking in, because it has been a bane to the designers but I see how easy it has become to fix.
| @@ -7,6 +7,8 @@ import { | |||
| } from '@tacc/core-components'; | |||
| import styles from './UserNews.module.css'; | |||
|
|
|||
| const NEWS_DASHBOARD_DISPLAY_LIMIT = 3; | |||
Comment on lines
+23
to
+27
| const projectData = data | ||
| ?.filter((prj) => | ||
| prj.allocations?.some((alloc) => alloc.status === 'Active') | ||
| ) | ||
| .slice(0, PROJECTS_DASHBOARD_DISPLAY_LIMIT); |
Comment on lines
+15
to
+17
| <Link to="/tickets" className={styles['viewall-action']}> | ||
| View all Tickets | ||
| </Link> |
There was a problem hiding this comment.
Added link to "View all Tickets".
jarosenb
added a commit
that referenced
this pull request
Oct 5, 2023
|
Exacerbates a bug. Bug must be fixed in tandem. I restored this work in #330, where I will also fix the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change UI so users can more clearly see where to "View all" Tickets, Projects, and News.
Related
requires feat: support different buttons for TicketCreateModal #318*requires feat: allow smaller*<TicketCreateModal>button #319-smalldisplay toTicketCreateModal#320 ** Without it, scrollbar can show on Dashboard "My Tickets", but design wants to avoid scrollbar
Changes
NEWS_DASHBOARD_DISPLAY_LIMITPROJECTS_DASHBOARD_DISPLAY_LIMITTesting
UI
The cut off System Status "Running Jobs" is a bug caused by #312, not this.
Outdated