feat: tup-490 increase portal font-size #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
force-pushed
the
task/tup-490-increase-portal-font-size
branch
4 times, most recently
from
2555d23 to
5498010
Compare
CSS Modules compose rules in @media does not respect query. So, pull the @media query into Mfa.module.css, thus no need to compose. This means c-step-panels leaves message and responsive layout to client. css-modules/css-modules#75
wesleyboar
force-pushed
the
task/tup-490-increase-portal-font-size
branch
from
5498010 to
ddc9afa
Compare
This was referenced Sep 6, 2023
Merged
wesleyboar
force-pushed
the
task/tup-490-increase-portal-font-size
branch
from
bd8007b to
b647f6a
Compare
wesleyboar
commented
Sep 6, 2023
There was a problem hiding this comment.
Notes for reviewers.
The GitHub annotations are unrelated to this PR. I fix them in #314.
There was a problem hiding this comment.
This prevents horizontal scrollbar on MFA section.
This complex fix is isolated in #315, but required here.
There was a problem hiding this comment.
This prevents horizontal scrollbar on MFA section.
This complex fix is isolated in #315, but required here.
There was a problem hiding this comment.
This prevents horizontal scrollbar on System Status section.
There was a problem hiding this comment.
These changes keeps User News font sizes the same.
wesleyboar
changed the title
wesleyboar
added a commit
that referenced
this pull request
Sep 7, 2023
Another PR may require this value to change further: #312
jarosenb
approved these changes
Sep 13, 2023
wesleyboar
added a commit
that referenced
this pull request
Sep 13, 2023
jarosenb
pushed a commit
that referenced
this pull request
Oct 5, 2023
* feat: add link in Dashboard to "View all tickets" * style: nx format:write * enhance: show less tickets (to avoid scrollbar) Another PR may require this value to change further: #312 * enhance: show less news (to avoid scrollbar) Also, do so via— NEWS_DASHBOARD_DISPLAY_LIMIT —to mimic clarity of—TICKETS_DASHBOARD_DISPLAY_LIMIT * fix: consistent text casing for "view all" * feat: limit projects on dash (to avoid scrollbar) Also, do so via— PROJECTS_DASHBOARD_DISPLAY_LIMIT —to mimic clarity of—TICKETS_DASHBOARD_DISPLAY_LIMIT * style: nx format:write * fix: align "View all Tickets" vert. center * Revert "fix: align "View all Tickets" vert. center" This reverts commit 6d62c21. The alignment will not be an issue after new branch: enhance/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button * fix: reduce dashboard display limit since #312 * fix: project ticket grid too much middle space Designers do not intend nor like big gap. It's been around since Portal. But it's been so difficult to fix… until `project-ticket-grid` came. I hadn't noticed the fix was possible until just now.
This was referenced Oct 5, 2023
wesleyboar
added a commit
that referenced
this pull request
Nov 14, 2023
#331) * feat: add link in Dashboard to "View all tickets" * style: nx format:write * enhance: show less tickets (to avoid scrollbar) Another PR may require this value to change further: #312 * enhance: show less news (to avoid scrollbar) Also, do so via— NEWS_DASHBOARD_DISPLAY_LIMIT —to mimic clarity of—TICKETS_DASHBOARD_DISPLAY_LIMIT * fix: consistent text casing for "view all" * feat: limit projects on dash (to avoid scrollbar) Also, do so via— PROJECTS_DASHBOARD_DISPLAY_LIMIT —to mimic clarity of—TICKETS_DASHBOARD_DISPLAY_LIMIT * style: nx format:write * fix: align "View all Tickets" vert. center * Revert "fix: align "View all Tickets" vert. center" This reverts commit 6d62c21. The alignment will not be an issue after new branch: enhance/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button * fix: reduce dashboard display limit since #312 * fix: project ticket grid too much middle space Designers do not intend nor like big gap. It's been around since Portal. But it's been so difficult to fix… until `project-ticket-grid` came. I hadn't noticed the fix was possible until just now. * Fix/tup 599 dashboard tall header (#337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Increase Portal UI font size, but ensure User News font size still matches CMS.
Related
Changes
Testing
main.<h1>size is +1pxbigger.(e.g. "Dashboard")
2pxbigger.(except nav links, unless Design says these should also be bigger)
(especially /portal/system-status)
992pxviewport width1200pxviewport width1400pxviewport widthUI
show all
1.
<h1>is Bigger2. Other Font is Bigger
<h2><th>pill
<td>nav text — unchanged
nav icon
3. Dashboard User News — unchanged
Date — unchanged
Title — unchanged
Summary — unchanged
4. No Horizontal Scrollbars
4.at.992px.mov
4.at.1200px.mov
4.at.1400px.mov