feat: support different buttons for TicketCreateModal #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TicketCreateModal <Button> has TypeScript "problem":
Type '{ children: ReactNode; type: "link" | "primary" | "secondary" | "tertiary" | "active" | undefined; size: "small" | "short" | "medium" | "long" | undefined; onClick: () => void; }' is not assignable to type 'IntrinsicAttributes & ButtonProps'.
Types of property 'type' are incompatible.
Type '"link" | "primary" | "secondary" | "tertiary" | "active" | undefined' is not assignable to type '"secondary" | "tertiary" | "active" | undefined'.
Type '"link"' is not assignable to type '"secondary" | "tertiary" | "active" | undefined'.ts(2322)
…ce/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button
…ce/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button
…ce/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button
…ce/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button
1. Reverse all the many changes to <Button>.
2. Allow <TicketCreateModal> to accept an element instead of jsut text.
- If an elment is passed, set onClick on it.
|
Superseded by #319. |
This was referenced Sep 8, 2023
wesleyboar
deleted the
enhance/tup-414-help-users-view-all-tickets--indirectly-support-small-size-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview / Changes
TicketCreateModalto use different size (or type) buttons.Related
required by feat: tup-414 help users "View all …" #317<TicketCreateModal>button #319Testing
UI