Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add -small display to TicketCreateModal #320

Merged
merged 5 commits into from
Sep 26, 2023
Merged

feat: add -small display to TicketCreateModal #320

merged 5 commits into from
Sep 26, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 14, 2023 •
edited
Loading

Overview / Changes

  1. Allow TicketCreateModal to use small buttons.
  2. Reduce size of [ + New Ticket ] on Dashboard.

Related

Testing

  1. Open Dashboard.
  2. Verify "+ New Ticket" button is smaller.
  3. Thus, see height of header title and button height are less different.

UI

before after
before after

@wesleyboar wesleyboar mentioned this pull request Sep 14, 2023
Closed
@wesleyboar wesleyboar requested a review from jarosenb September 14, 2023 00:25
@wesleyboar wesleyboar mentioned this pull request Sep 26, 2023
Closed
@wesleyboar
Copy link
Member Author

Merging based on offline discussion and @jarosenb's commit ba14b22 to make this easier to udnerstand.

@wesleyboar wesleyboar merged commit f38c8d8 into main Sep 26, 2023
1 check passed
@wesleyboar wesleyboar deleted the feat/allow-small-button-for-ticketcreatemodal branch September 26, 2023 21:27
@wesleyboar wesleyboar mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarosenb jarosenb Awaiting requested review from jarosenb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar