fix: tup-571 mfa ui not responsive #315
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Repair MFA responsive layout CSS so that narrow-screen layout is used.
Related
Changes
c-step-panels
to not assume responsive layoutTesting
Open MFA pairing (or unpairing) view.
Make message appear (e.g. click button to generate QR code).
On wide screen (992px or wider), layout should be "good".
(click for details)
To do so, live-edit message text to be long enough to wrap.
To do so, make window so short that scrollbar appears.
On narrow screen (991px or narrower), layout should be "good".
(click for details)
To do so, live-edit message text to be long enough to wrap.
To do so, make window so short that scrollbar appears.
If you notice the horizontal scrollbar, then know that it is fixed in #315.
UI
Wide
Narrow
* About the
<TextFieldCopy>
stretch…The
<TextFieldCopy>
will try to stretch to fill available space.To avoid (subjectively) worst case scenario, wide-screen sets
width: max-content
on.mfa-message
to prevent that, assuming normal-length message text, but with caveats:<TextFieldCopy>
opportunity to stretch on wide screen.<TextFieldCopy>
is allowed to stretch on a narrow screen, because were a narrow screen to usewidth: max-content
on.mfa-message
, long message text would stretch to fill entire width of screen (which just looked weird to me).If this solution looks weird to anyone else, tell me and we can let designers decide what they want, which might change the challenge for the better.
Another solution may be to change
<TextFieldCopy>
to not stretch. (That change can be performed independent of this PR.)