Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tup-589, font size increase should only be for portal #321

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 15, 2023

Overview

Portal font size update was done via TUP-CMS styles instead of TUP-UI styles. Whoops.

Related

Changes

  • moved portal font-size update from tup-cms to tup-ui

Testing & UI

1. CMS Main Menu Font Size
cms portal
cms font size value portal font size value

The font size is still visually different (by 2 pixels of height). But, that is a long-standing (forgotten) production bug not caused by #312.

2. Portal Font Size is Still Bigger (copied from #312)

1. <h1> is Bigger

before after
1 h1 size old 1 h1 size new

2. Other Font is Bigger

<h2>

before after
2 other A size old 2 other A size new

<th>

before after
2 other B size old 2 other B size new

pill

before after
2 other C size old 2 other C size new

<td>

before after
2 other D size old 2 other D size new

nav text — unchanged

before after
2 other E size old 2 other E size new

nav icon

before after
2 other F size old 2 other F size new

3. Dashboard User News — unchanged

Date — unchanged

before cms after
3 news A size old 3 news A size cms 3 news A size new

Title — unchanged

before cms after
3 news B size old 3 news B size cms 3 news B size new

Summary — unchanged

before cms after
3 news C size old 3 news C size cms 3 news C size new

4. No Horizontal Scrollbars

4.at.992px.mov
4.at.1200px.mov
4.at.1400px.mov

@wesleyboar wesleyboar changed the title fix: tup-589, portal font size wrongly via tup-cms fix: tup-589, portal font size should only be for tup-ui Sep 15, 2023
@wesleyboar wesleyboar changed the title fix: tup-589, portal font size should only be for tup-ui fix: tup-589, font size increase should only be for portal Sep 15, 2023
@wesleyboar wesleyboar marked this pull request as ready for review September 15, 2023 18:05
@wesleyboar wesleyboar marked this pull request as draft September 15, 2023 18:06
@wesleyboar wesleyboar marked this pull request as ready for review September 15, 2023 18:13
@wesleyboar wesleyboar merged commit bc60470 into main Sep 15, 2023
@wesleyboar wesleyboar deleted the fix/tup-589-portal-font-size-via-tup-cms-instead-of-tup-ui branch September 15, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant