fix: tup-589, font size increase should only be for portal #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Portal font size update was done via TUP-CMS styles instead of TUP-UI styles. Whoops.
Related
Changes
tup-cms
totup-ui
Testing & UI
1. CMS Main Menu Font Size
The font size is still visually different (by 2 pixels of height). But, that is a long-standing (forgotten) production bug not caused by #312.
2. Portal Font Size is Still Bigger (copied from #312)
1.
<h1>
is Bigger2. Other Font is Bigger
<h2>
<th>
pill
<td>
nav text — unchanged
nav icon
3. Dashboard User News — unchanged
Date — unchanged
Title — unchanged
Summary — unchanged
4. No Horizontal Scrollbars
4.at.992px.mov
4.at.1200px.mov
4.at.1400px.mov