Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.19 [email protected] 1.18.5 #107165

Closed
wants to merge 4 commits into from
Closed

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Aug 2, 2022

Created with brew bump-formula-pr.

resource blocks may require updates.

@bayandin bayandin added the long build Set a long timeout for formula testing label Aug 2, 2022
@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Aug 2, 2022
@bayandin bayandin added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 2, 2022
@carlocab
Copy link
Member

carlocab commented Aug 2, 2022

We want CI-build-dependents-from-source for major version bumps, no? Though we've got so many long-running PR jobs going I'm a bit tempted to skip it for now.

@bayandin
Copy link
Member Author

bayandin commented Aug 2, 2022

We want CI-build-dependents-from-source for major version bumps, no?

Hmm, shouldn't the label be set automatically?

Though we've got so many long-running PR jobs going I'm a bit tempted to skip it for now.

We could try, at least once.

@carlocab
Copy link
Member

carlocab commented Aug 2, 2022

Hmm, shouldn't the label be set automatically?

It should, but I think our triage workflow gets confused as soon as a PR touches more than one file.

@bayandin bayandin added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Aug 2, 2022
@Bo98 Bo98 added the CI-linux-self-hosted Build on Linux self-hosted runner label Aug 2, 2022
@Bo98
Copy link
Member

Bo98 commented Aug 2, 2022

go-critic and golangci-lint need revision bumps.

@bayandin bayandin added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 2, 2022
@Bo98 Bo98 removed the CI-linux-self-hosted Build on Linux self-hosted runner label Aug 3, 2022
@bayandin

This comment was marked as outdated.

@carlocab
Copy link
Member

carlocab commented Aug 3, 2022

octant is pre-existing. #106816

Most of the rest (build constraints, garbage collector, Go version complaints) can probably be fixed by building with a [email protected].

That still leaves a few failures, though.

@andig
Copy link
Contributor

andig commented Aug 3, 2022

@carlocab are you planning to fix Go 1.18 for part of the packages? I could help tracking the bug ones as long as Go is concerned (not python ...).

@bayandin
Copy link
Member Author

bayandin commented Aug 3, 2022

a bunch of them should be fixed by switching to [email protected] (will do it as soon the CI run is done)

@andig
Copy link
Contributor

andig commented Aug 3, 2022

For https://github.com/go4org/unsafe-assume-no-moving-gc 1.19 is already marked safe, I'll open upstream issues.

@bayandin
Copy link
Member Author

bayandin commented Aug 3, 2022

Formulae that require some attention (have unknown failure):

  • brew install --build-from-source grafana
  • brew install --build-from-source k3d
  • brew install --build-from-source liqoctl
  • brew install --build-from-source sync_gateway
  • brew install --build-from-source traefik@1

@carlocab
Copy link
Member

carlocab commented Aug 3, 2022

I think grafana is also pre-existing. The error looks similar to #107028.

@andig
Copy link
Contributor

andig commented Aug 3, 2022

traefik@1 is not related to Go at all- no idea. Must be pre-existing?

@carlocab
Copy link
Member

carlocab commented Aug 3, 2022

traefik@1 is not related to Go at all- no idea. Must be pre-existing?

Maybe. Do you see a similar error with

brew install -s traefik@1

?

@andig
Copy link
Contributor

andig commented Aug 3, 2022

traefik@1 is not related to Go at all- no idea. Must be pre-existing?

Maybe. Do you see a similar error with

brew install -s traefik@1

?

Traefik has a different issue for me, but still broken:

==> Installing traefik@1
==> yarn upgrade
==> yarn install
==> yarn run build
Last 15 lines from /Users/andig/Library/Logs/Homebrew/traefik@1/03.yarn:
    at loadLoader (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/loadLoader.js:32:11)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:165:10)
    at /private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:176:18
    at loadLoader (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/loadLoader.js:47:3)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:165:10)
    at /private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:176:18
    at loadLoader (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/loadLoader.js:47:3)
    at iteratePitchingLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:169:2)
    at runLoaders (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/loader-runner/lib/LoaderRunner.js:365:2)
    at NormalModule.doBuild (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/webpack/lib/NormalModule.js:182:3)
    at NormalModule.build (/private/tmp/traefikA1-20220803-18031-17oz0fj/traefik-1.7.34/webui/node_modules/webpack/lib/NormalModule.js:275:15)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@bayandin
Copy link
Member Author

bayandin commented Aug 4, 2022

I've pushed everything I have.
Meanwhile, while we're waiting for a free CI-long-timeout slot, feel free to check failed formulae on other systems (I've checked only 12-arm64 runner). Here's a link to the previous run: https://github.com/Homebrew/homebrew-core/actions/runs/2785592300

Formula/gomplate.rb Outdated Show resolved Hide resolved
@bayandin bayandin added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 5, 2022
@iMichka iMichka added the no long build conflict Do not allow merging other pull requests when files conflict with this one label Aug 5, 2022
@bayandin
Copy link
Member Author

bayandin commented Aug 5, 2022

So far, after 12-arm64, 11-arm64, linux:

Unknown:

  • brew test --retry --verbose func-e (on 11-arm64 only)
 ==> Testing func-e
  ==> /opt/homebrew/Cellar/func-e/1.1.3/bin/func-e run --version
  dyld: Symbol not found: __ZNKSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE3strEv
    Referenced from: /private/tmp/func-e-test-20220805-14034-7m57hu/.func-e/versions/1.22.2/bin/envoy (which was built for Mac OS X 12.3)
    Expected in: /usr/lib/libc++.1.dylib
  • brew install --build-from-source sync_gateway (on 12-arm64 only)
 Error: Failure while executing; `python rewrite-manifest.sh --manifest-url file:///private/tmp/sync_gateway-20220805-623-avs958/manifest/default.xml --project-name sync_gateway --set-revision e54a62741bb28f3e54a6599c21c739df9a9dad76` exited with 127. Here's the output:

Switch to 1.18:

  • brew install --build-from-source yorkie
  • brew test --retry --verbose loki

Pre-existing:

  • brew fetch --build-from-source --retry krakend # https://github.com/krakendio/krakend-ce/issues/541
  • brew fetch --build-from-source --retry whalebrew # https://github.com/whalebrew/whalebrew/issues/192
  • brew install --build-from-source octant # preexisting https://github.com/Homebrew/homebrew-core/pull/106816
  • brew install --verbose --build-bottle istioctl # preexisting https://github.com/Homebrew/homebrew-core/pull/107108

@carlocab
Copy link
Member

carlocab commented Aug 5, 2022

I suggest moving the [email protected] addition along with its dependents (the ones that build, anyway) into a separate PR to help simplify this one.

We also don't need new bottles for the ones that just have a build-only dependency on [email protected] anyway.

@iMichka iMichka mentioned this pull request Aug 5, 2022
@bayandin
Copy link
Member Author

bayandin commented Aug 6, 2022

I suggest moving the [email protected] addition along with its dependents (the ones that build, anyway) into a separate PR to help simplify this one.

We also don't need new bottles for the ones that just have a build-only dependency on [email protected] anyway.

Ok, let's try!

@bayandin bayandin removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Aug 6, 2022
@bayandin bayandin changed the title go 1.19 go 1.19 [email protected] 1.18.5 Aug 6, 2022
@bayandin bayandin removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 6, 2022
@bayandin bayandin requested a review from carlocab August 6, 2022 14:35
carlocab
carlocab previously approved these changes Aug 6, 2022
@BrewTestBot
Copy link
Member

:shipit: @bayandin has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ @bayandin bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review August 6, 2022 14:54

bottle publish failed

@BrewTestBot
Copy link
Member

:shipit: @bayandin has triggered a merge.

@bayandin bayandin deleted the bump-go-1.19 branch August 6, 2022 15:04
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing no long build conflict Do not allow merging other pull requests when files conflict with this one outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants