Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Go 1.19 #6831

Closed
andig opened this issue Aug 3, 2022 · 0 comments · Fixed by #6833
Closed

Support Go 1.19 #6831

andig opened this issue Aug 3, 2022 · 0 comments · Fixed by #6833

Comments

@andig
Copy link

andig commented Aug 3, 2022

Homebrew/homebrew-core#107165 fails due to

panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.

This can be fixed by upgrading go4.org/unsafe/assume-no-moving-gc according to quic-go/quic-go#3491
dannykopping pushed a commit to dannykopping/loki that referenced this issue Aug 3, 2022
Support building against Go 1.19
1e3c662 
Fixes grafana#6831

Hat-tip to @rfratto in grafana/agent#1985

Signed-off-by: Danny Kopping <[email protected]>
@dannykopping dannykopping mentioned this issue Aug 3, 2022
Merged
dannykopping pushed a commit that referenced this issue Aug 3, 2022
Support building against Go 1.19 (#6833)
c63928e 
* Support building against Go 1.19

Fixes #6831

Hat-tip to @rfratto in grafana/agent#1985

Signed-off-by: Danny Kopping <[email protected]>

* go mod tidy

Signed-off-by: Danny Kopping <[email protected]>
lxwzy pushed a commit to lxwzy/loki that referenced this issue Nov 7, 2022
@lxwzy
Support building against Go 1.19 (grafana#6833)
78e06e1 
* Support building against Go 1.19

Fixes grafana#6831

Hat-tip to @rfratto in grafana/agent#1985

Signed-off-by: Danny Kopping <[email protected]>

* go mod tidy

Signed-off-by: Danny Kopping <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support building against Go 1.19 dannykopping/loki
1 participant
@andig