Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when building Docker images with Go 1.19 #378

Closed
hackerwins opened this issue Aug 3, 2022 · 6 comments · Fixed by #425
Closed

Error when building Docker images with Go 1.19 #378

hackerwins opened this issue Aug 3, 2022 · 6 comments · Fixed by #425
Labels
cleanup 🧹 Paying off technical debt

Comments

@hackerwins
Copy link
Member

hackerwins commented Aug 3, 2022 •
edited
Loading

Description:

Error when building Docker images with Go 1.19

https://github.com/yorkie-team/yorkie/runs/7644025991?check_suite_focus=true

To avoid the error, we decided to fix the version to 1.18.

Why:

  • We should support Go 1.19 in the future.
@hackerwins hackerwins added the cleanup 🧹 Paying off technical debt label Aug 3, 2022
@andig
Copy link

andig commented Aug 3, 2022

This blocks the brew package build: Homebrew/homebrew-core#107165

@andig andig mentioned this issue Aug 3, 2022
Closed
@hackerwins
Copy link
Member Author

@andig Thanks for letting me know.

@blurfx
Copy link
Member

blurfx commented Oct 8, 2022 •
edited
Loading

It seems to be resolved in the Go 1.19.2 release. It would be good to try building with Go 1.19.2.

@hackerwins hackerwins mentioned this issue Oct 8, 2022
Merged
2 tasks
@hackerwins
Copy link
Member Author

@blurfx Thanks for letting me know.

@andig
Copy link

andig commented Oct 8, 2022

@hackerwins please don't forget to unpin Go version in the homebrew repo

@hackerwins
Copy link
Member Author

@andig Thanks. I will unpin it when we release the next version.

@hackerwins hackerwins mentioned this issue Nov 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump up Go to 1.19.2 yorkie-team/yorkie
3 participants
@andig @hackerwins @blurfx