Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc formulae: switch to [email protected] #107451

Closed
wants to merge 19 commits into from
Closed

Misc formulae: switch to [email protected] #107451

wants to merge 19 commits into from

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Aug 6, 2022

Extracted from #107165, should be rebased after go 1.19 is merged.

These formulae don't work with go 1.19, so let's switch them to [email protected].

@bayandin bayandin added do not merge CI-no-bottles Merge without publishing bottles labels Aug 6, 2022
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Aug 6, 2022
@bayandin bayandin marked this pull request as ready for review August 6, 2022 15:08
@bayandin bayandin added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing and removed do not merge CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Aug 6, 2022
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Aug 6, 2022
@bayandin bayandin added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 6, 2022
@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 7, 2022
@cho-m
Copy link
Member

cho-m commented Aug 7, 2022

istioctl is existing failure. I think it may be something in brew as build is now picking /usr/bin/curl rather than the dependency for Homebrew's curl.

cho-m
cho-m previously approved these changes Aug 7, 2022
View reviewed changes
@bayandin
Copy link
Member Author

bayandin commented Aug 8, 2022 •
edited
Loading

I've switched istioctl to [email protected] in #107108.

And because it was the only failure, going to rerun the job with CI-Syntax-only to avoid another long build

@bayandin bayandin added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed long build Set a long timeout for formula testing labels Aug 8, 2022
@bayandin bayandin requested a review from cho-m August 8, 2022 08:26
@bayandin bayandin mentioned this pull request Aug 8, 2022
Closed
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cho-m cho-m cho-m approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bayandin @cho-m @BrewTestBot @carlocab