Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupons: Remove outdated survey #14891

Merged
merged 12 commits into from
Jan 20, 2025
Merged

Conversation

itsmeichigo
Copy link
Contributor

Part of #14529

Description

This PR removes the feedback banner on the coupon list.

Steps to reproduce

  • Log in to a test store with existing coupons.
  • Navigate to Menu tabs > Coupons.
  • Confirm that the feedback banner is no longer available on the top of the list.

Testing information

Tested with simulator iPhone 16 Pro iOS 18.2 and confirmed that the feedback banner is removed from the coupon list.

Screenshots

Before After

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: coupons Related to basic fulfillment such as order tracking. labels Jan 16, 2025
@itsmeichigo itsmeichigo added this to the 21.5 milestone Jan 16, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 16, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14891-59d6651
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit59d6651
App Center BuildWooCommerce - Prototype Builds #12586
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pmusolino pmusolino self-assigned this Jan 16, 2025
Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: it works as expected

Base automatically changed from task/14529-remove-product-creation-ai-survey to trunk January 20, 2025 03:12
@itsmeichigo itsmeichigo enabled auto-merge January 20, 2025 03:12
@itsmeichigo itsmeichigo merged commit 268c7c0 into trunk Jan 20, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the task/14529-remove-coupon-survey branch January 20, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: coupons Related to basic fulfillment such as order tracking. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants