-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping Labels: Remove outdated survey #14889
Conversation
…-shipping-label-survey
…-shipping-label-survey
…-shipping-label-survey
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this cleanup!
A couple minor things I noticed are still around:
FeedbackType
still containsshippingLabelsRelease3
(and it's referred to inInAppFeedbackCardVisibilityUseCase
).WooAnalyticsEvent
still has ashippingLabelsRelease3
case for theFeedbackContext
(for tracking when surveys are shown).
Both of those could be cleaned up but aren't blockers.
Thanks, @rachelmcr for the review!
Good catch! I've pushed a commit to remove this 595cb79.
I removed this as part of #14891. |
Part of #14529
Description
As part of the cleanup of outdated surveys, this PR removes the feedback banner for the shipping label feature on the order details screen.
Steps to reproduce
Testing information
Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the feedback banner is no longer available on the order details screen.
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: