Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping Labels: Remove outdated survey #14889

Merged
merged 12 commits into from
Jan 20, 2025

Conversation

itsmeichigo
Copy link
Contributor

Part of #14529

Description

As part of the cleanup of outdated surveys, this PR removes the feedback banner for the shipping label feature on the order details screen.

Steps to reproduce

  • Log in to a store with WCShip plugin set up.
  • Navigate to the Orders tab and open an order eligible for creating shipping labels.
  • Confirm that the feedback banner for shipping labels is no longer available on the top.

Testing information

Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the feedback banner is no longer available on the order details screen.

Screenshots

Before After

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jan 16, 2025
@itsmeichigo itsmeichigo added this to the 21.5 milestone Jan 16, 2025
@itsmeichigo itsmeichigo marked this pull request as ready for review January 16, 2025 04:47
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 16, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14889-595cb79
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit595cb79
App Center BuildWooCommerce - Prototype Builds #12583
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pmusolino pmusolino self-assigned this Jan 17, 2025
@rachelmcr rachelmcr assigned rachelmcr and unassigned pmusolino Jan 17, 2025
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this cleanup!

A couple minor things I noticed are still around:

  • FeedbackType still contains shippingLabelsRelease3 (and it's referred to in InAppFeedbackCardVisibilityUseCase).
  • WooAnalyticsEvent still has a shippingLabelsRelease3 case for the FeedbackContext (for tracking when surveys are shown).

Both of those could be cleaned up but aren't blockers.

Base automatically changed from task/14529-move-inactive-survey to trunk January 20, 2025 02:26
@itsmeichigo
Copy link
Contributor Author

Thanks, @rachelmcr for the review!

FeedbackType still contains shippingLabelsRelease3 (and it's referred to in InAppFeedbackCardVisibilityUseCase).

Good catch! I've pushed a commit to remove this 595cb79.

WooAnalyticsEvent still has a shippingLabelsRelease3 case for the FeedbackContext (for tracking when surveys are shown).

I removed this as part of #14891.

@itsmeichigo itsmeichigo enabled auto-merge January 20, 2025 02:39
@itsmeichigo itsmeichigo merged commit 9c8dcc5 into trunk Jan 20, 2025
11 of 12 checks passed
@itsmeichigo itsmeichigo deleted the task/14529-remove-shipping-label-survey branch January 20, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants