Coupons: Remove outdated survey

RELEASE-NOTES.txt

@@ -7,6 +7,7 @@
 - [Internal] Removed feedback survey for Store Setup feature [https://github.com/woocommerce/woocommerce-ios/pull/14888]
 - [Internal] Removed feedback survey for shipping label creation [https://github.com/woocommerce/woocommerce-ios/pull/14889]
 - [Internal] Removed feedback survey for product creation AI [https://github.com/woocommerce/woocommerce-ios/pull/14890]
+- [Internal] Removed feedback survey for coupons list [https://github.com/woocommerce/woocommerce-ios/pull/14891]
 
 21.4
 -----

WooCommerce/Classes/System/WooConstants.swift

@@ -254,11 +254,6 @@ extension WooConstants {
         case orderCreationFeedback = "https://automattic.survey.fm/woo-app-order-creation-production"
 #endif
 
-#if DEBUG
-        case couponManagementFeedback = "https://automattic.survey.fm/woo-app-coupon-management-testing"
-#else
-        case couponManagementFeedback = "https://automattic.survey.fm/woo-app-coupon-management-production"
-#endif
         /// URL for the Enable Cash on Delivery (or Pay in Person) onboarding step's learn more link using the Stripe plugin
         ///
         case stripeCashOnDeliveryLearnMore = "https://woocommerce.com/document/stripe/accept-in-person-payments-with-stripe/#section-8"

WooCommerce/Classes/ViewRelated/Coupons/CouponListView.swift

@@ -9,7 +9,6 @@ struct CouponListView: UIViewControllerRepresentable {
 
     func makeUIViewController(context: Self.Context) -> CouponListViewController {
         let viewController = CouponListViewController(siteID: siteID,
-                                                      showFeedbackBannerIfAppropriate: false,
                                                       emptyStateActionTitle: emptyStateActionTitle,
                                                       emptyStateAction: emptyStateAction,
                                                       onCouponSelected: onCouponSelected)

WooCommerce/Classes/ViewRelated/Coupons/CouponListViewController.swift

@@ -36,21 +36,19 @@ final class CouponListViewController: UIViewController, GhostableViewController
     private var subscriptions: Set<AnyCancellable> = []
 
     private lazy var dataSource: UITableViewDiffableDataSource<Section, CouponListViewModel.CellViewModel> = makeDataSource()
-    private lazy var topBannerView: TopBannerView = createFeedbackBannerView()
 
     private var onDataLoaded: ((Bool) -> Void)?
     private let emptyStateAction: (() -> Void)
     private let emptyStateActionTitle: String
     private let onCouponSelected: ((Coupon) -> Void)
 
     init(siteID: Int64,
-         showFeedbackBannerIfAppropriate: Bool,
          emptyStateActionTitle: String,
          onDataLoaded: ((Bool) -> Void)? = nil,
          emptyStateAction: @escaping (() -> Void),
          onCouponSelected: @escaping ((Coupon) -> Void)) {
         self.siteID = siteID
-        self.viewModel = CouponListViewModel(siteID: siteID, showFeedbackBannerIfAppropriate: showFeedbackBannerIfAppropriate)
+        self.viewModel = CouponListViewModel(siteID: siteID)
         self.onDataLoaded = onDataLoaded
         self.emptyStateAction = emptyStateAction
         self.emptyStateActionTitle = emptyStateActionTitle
@@ -101,25 +99,6 @@ final class CouponListViewController: UIViewController, GhostableViewController
             }
             .store(in: &subscriptions)
 
-        viewModel.$shouldDisplayFeedbackBanner
-            .removeDuplicates()
-            .sink { [weak self] isVisible in
-                guard let self = self else { return }
-                if isVisible {
-                    // Configure header container view
-                    let headerContainer = UIView(frame: CGRect(x: 0, y: 0, width: Int(self.tableView.frame.width), height: 0))
-                    headerContainer.addSubview(self.topBannerView)
-                    headerContainer.pinSubviewToSafeArea(self.topBannerView)
-
-                    self.tableView.tableHeaderView = headerContainer
-                    self.tableView.updateHeaderHeight()
-                } else {
-                    self.topBannerView.removeFromSuperview()
-                    self.tableView.tableHeaderView = nil
-                }
-            }
-            .store(in: &subscriptions)
-
         viewModel.$couponViewModels
             .map { viewModels -> Bool in
                 viewModels.isNotEmpty
@@ -236,39 +215,6 @@ private extension CouponListViewController {
             }
         )
     }
-
-    func createFeedbackBannerView() -> TopBannerView {
-        let giveFeedbackAction = TopBannerViewModel.ActionButton(title: Localization.giveFeedbackAction) { [weak self] _ in
-            ServiceLocator.analytics.track(event: .featureFeedbackBanner(context: .couponManagement, action: .gaveFeedback))
-            self?.presentCouponsFeedback()
-        }
-        let dismissAction = TopBannerViewModel.ActionButton(title: Localization.dismissAction) { [weak self] _ in
-            ServiceLocator.analytics.track(event: .featureFeedbackBanner(context: .couponManagement, action: .dismissed))
-            self?.viewModel.dismissFeedbackBanner()
-        }
-        let expandedStateChangeHandler: (() -> Void)? = { [weak self] in
-            self?.tableView.updateHeaderHeight()
-        }
-        let actions = [giveFeedbackAction, dismissAction]
-        let viewModel = TopBannerViewModel(title: Localization.feedbackBannerTitle,
-                                           infoText: Localization.feedbackBannerContent,
-                                           icon: .speakerIcon.withRenderingMode(.alwaysTemplate),
-                                           iconTintColor: .wooCommercePurple(.shade50),
-                                           isExpanded: false,
-                                           topButton: .chevron(handler: expandedStateChangeHandler),
-                                           actionButtons: actions)
-        let topBannerView = TopBannerView(viewModel: viewModel)
-        topBannerView.translatesAutoresizingMaskIntoConstraints = false
-        return topBannerView
-    }
-
-    /// Presents coupons survey
-    ///
-    func presentCouponsFeedback() {
-        // Present survey
-        let navigationController = SurveyCoordinatingController(survey: .couponManagement)
-        present(navigationController, animated: true, completion: nil)
-    }
 }
 
 
@@ -393,12 +339,6 @@ private extension CouponListViewController {
             comment: "The action button on the placeholder overlay on the coupon list screen when coupons are disabled for the store."
         )
 
-        static let feedbackBannerTitle = NSLocalizedString("View and edit coupons", comment: "Title of the feedback banner on the coupon list screen")
-        static let feedbackBannerContent = NSLocalizedString(
-            "We’ve been working on making it possible to view and edit coupons from your device!",
-            comment: "Content of the feedback banner on the coupon list screen"
-        )
-
         static let giveFeedbackAction = NSLocalizedString("Give feedback", comment: "Title of the feedback action button on the coupon list screen")
         static let dismissAction = NSLocalizedString("Dismiss", comment: "Title of the dismiss action button on the coupon list screen")
 

WooCommerce/Classes/ViewRelated/Coupons/CouponListViewModel.swift

@@ -32,10 +32,6 @@ final class CouponListViewModel {
     ///
     @Published private(set) var state: CouponListState = .initialized
 
-    @Published private(set) var shouldDisplayFeedbackBanner: Bool = false
-
-    @Published private var isFeedbackBannerEnabledInAppSettings: Bool = false
-
     /// couponViewModels: ViewModels for the cells representing Coupons
     ///
     @Published private(set) var couponViewModels: [CellViewModel] = []
@@ -64,7 +60,6 @@ final class CouponListViewModel {
     // MARK: - Initialization and setup
     //
     init(siteID: Int64,
-         showFeedbackBannerIfAppropriate: Bool = true,
          syncingCoordinator: SyncingCoordinatorProtocol = SyncingCoordinator(),
          storesManager: StoresManager = ServiceLocator.stores,
          storageManager: StorageManagerType = ServiceLocator.storageManager,
@@ -78,10 +73,6 @@ final class CouponListViewModel {
 
         configureSyncingCoordinator()
         configureResultsController()
-
-        if showFeedbackBannerIfAppropriate {
-            configureFeedbackBannerVisibility()
-        }
     }
 
     func buildCouponViewModels() {
@@ -127,19 +118,6 @@ final class CouponListViewModel {
         syncingCoordinator.ensureNextPageIsSynchronized(lastVisibleIndex: indexPath.row)
     }
 
-    /// Mark feedback request as dismissed and update banner visibility
-    ///
-    func dismissFeedbackBanner() {
-        let action = AppSettingsAction.updateFeedbackStatus(type: .couponManagement,
-                                                            status: .dismissed) { [weak self] result in
-            if let error = result.failure {
-                DDLogError("⛔️ Error updating feedback visibility for coupon management: \(error)")
-            }
-            self?.isFeedbackBannerEnabledInAppSettings = false
-        }
-        storesManager.dispatch(action)
-    }
-
     /// Enable coupons for the store
     ///
     func enableCoupons() {
@@ -193,28 +171,6 @@ private extension CouponListViewModel {
         syncingCoordinator.delegate = self
     }
 
-    func configureFeedbackBannerVisibility() {
-        checkAppSettingsForFeedbackBannerVisibility()
-        $state.combineLatest($isFeedbackBannerEnabledInAppSettings)
-            .map { state, feedbackBannerVisibility -> Bool in
-                state.shouldShowTopBanner && feedbackBannerVisibility
-            }
-            .assign(to: &$shouldDisplayFeedbackBanner)
-    }
-
-    func checkAppSettingsForFeedbackBannerVisibility() {
-        let action = AppSettingsAction.loadFeedbackVisibility(type: .couponManagement) { [weak self] result in
-            switch result {
-            case .success(let visible):
-                self?.isFeedbackBannerEnabledInAppSettings = visible
-            case.failure(let error):
-                self?.isFeedbackBannerEnabledInAppSettings = false
-                DDLogError("⛔️ Error load feedback visibility for coupon management: \(error)")
-            }
-        }
-        storesManager.dispatch(action)
-    }
-
     /// Check whether coupons are enabled for this store.
     ///
     func loadCouponSetting(completionHandler: @escaping ((Result<Bool, Error>) -> Void)) {

WooCommerce/Classes/ViewRelated/Coupons/EnhancedCouponListViewController.swift

@@ -66,11 +66,10 @@ final class EnhancedCouponListViewController: UIViewController {
 private extension EnhancedCouponListViewController {
     func configureCouponListViewController() {
         let couponListViewController = CouponListViewController(siteID: siteID,
-                                                            showFeedbackBannerIfAppropriate: true,
-                                                            emptyStateActionTitle: Localization.createCouponAction,
-                                                            onDataLoaded: configureNavigationBarItems,
-                                                            emptyStateAction: displayCouponTypeBottomSheet,
-                                                            onCouponSelected: showDetails)
+                                                                emptyStateActionTitle: Localization.createCouponAction,
+                                                                onDataLoaded: configureNavigationBarItems,
+                                                                emptyStateAction: displayCouponTypeBottomSheet,
+                                                                onCouponSelected: showDetails)
 
         couponListViewController.view.translatesAutoresizingMaskIntoConstraints = false
         addChild(couponListViewController)

WooCommerce/Classes/ViewRelated/Survey/SurveyViewController.swift

@@ -66,7 +66,6 @@ extension SurveyViewController {
         case productsFeedback
         case addOnsI1
         case orderCreation
-        case couponManagement
         case orderFormShippingLines
 
         fileprivate var url: URL {
@@ -91,11 +90,6 @@ extension SurveyViewController {
                     .asURL()
                     .tagPlatform("ios")
                     .tagAppVersion(Bundle.main.bundleVersion())
-            case .couponManagement:
-                return WooConstants.URLs.couponManagementFeedback
-                    .asURL()
-                    .tagPlatform("ios")
-                    .tagAppVersion(Bundle.main.bundleVersion())
             case .orderFormShippingLines:
                 return WooConstants.URLs.orderCreationShippingFeedback
                     .asURL()
@@ -111,7 +105,6 @@ extension SurveyViewController {
             case .productsFeedback,
                     .addOnsI1,
                     .orderCreation,
-                    .couponManagement,
                     .orderFormShippingLines:
                 return Localization.giveFeedback
             }
@@ -128,8 +121,6 @@ extension SurveyViewController {
                 return .addOnsI1
             case .orderCreation:
                 return .orderCreation
-            case .couponManagement:
-                return .couponManagement
             case .orderFormShippingLines:
                 return .orderFormShippingLines
             }