This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
FilterPicker does not forward all props to Search component #6062
Labels
focus: components
Issues for woocommerce components
focus: marketing
Related to Marketing Features
needs: documentation
The issue/PR requires documentation to be added.
type: bug
The issue is a confirmed bug.
Comments
tomalec
added
type: bug
The issue is a confirmed bug.
focus: components
Issues for woocommerce components
needs: documentation
The issue/PR requires documentation to be added.
labels
Jan 13, 2021
6 tasks
tomalec
added a commit
to woocommerce/google-listings-and-ads
that referenced
this issue
Jan 13, 2021
Move filter configuration to a separate file. Subfilter is still not functional due to issues with Search autocomplete config: - woocommerce/woocommerce-admin#6061 - woocommerce/woocommerce-admin#6062
1 task
tomalec
added a commit
that referenced
this issue
Apr 25, 2021
Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided. Fixes: #6062.
tomalec
added a commit
that referenced
this issue
Apr 25, 2021
Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided. Fixes: #6062.
This was referenced Apr 25, 2021
jeffstieler
added a commit
that referenced
this issue
Apr 27, 2021
* Add a Basic test for FilterPicker. Test that it renders the basic storybook example without throwing an error. Move `path` in Storybooks example to a parameter, to allow setting it in unit tests. * Forward `autocompleter` prop from `FilterPicker` to `Search`. Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided. Fixes: #6062. * Add changelog entry. * Move `FilterPicker` config creation closer to tests that use it. * Remove unused type prop from `FilterPicker` tests. Addresses https://github.com/woocommerce/woocommerce-admin/pull/6880/files#r620285400. * Add changelog note also to `CHANGELOG.md`. Co-authored-by: Jeff Stieler <[email protected]>
This was referenced Apr 29, 2021
tomalec
added a commit
to woocommerce/google-listings-and-ads
that referenced
this issue
May 20, 2021
as those fixes were released in `@woocommerce/components`: - woocommerce/woocommerce-admin#6890, - woocommerce/woocommerce-admin#6062
tomalec
added a commit
to woocommerce/google-listings-and-ads
that referenced
this issue
Nov 25, 2021
as those fixes were released in `@woocommerce/components`: - woocommerce/woocommerce-admin#6890, - woocommerce/woocommerce-admin#6062 Remove no longer needed dependencies.
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this issue
Mar 18, 2022
…erce/woocommerce-admin#6880) * Add a Basic test for FilterPicker. Test that it renders the basic storybook example without throwing an error. Move `path` in Storybooks example to a parameter, to allow setting it in unit tests. * Forward `autocompleter` prop from `FilterPicker` to `Search`. Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided. Fixes: woocommerce/woocommerce-admin#6062. * Add changelog entry. * Move `FilterPicker` config creation closer to tests that use it. * Remove unused type prop from `FilterPicker` tests. Addresses https://github.com/woocommerce/woocommerce-admin/pull/6880/files#r620285400. * Add changelog note also to `CHANGELOG.md`. Co-authored-by: Jeff Stieler <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: components
Issues for woocommerce components
focus: marketing
Related to Marketing Features
needs: documentation
The issue/PR requires documentation to be added.
type: bug
The issue is a confirmed bug.
Describe the bug
I'm trying to set up a
<FilterPicker>
with a Search for a customtype
. I'm not able to, as for custom type I have to provideautocompleter
to the<Search>
component, but<FilterProvider>
does not forward this config. That results inTo Reproduce
Steps to reproduce the behavior:
<filterPicker>
with subfileter that contains a Search for custom type:Expected behavior
The component should render, with a specified autocompleter.
Screenshots
Desktop (please complete the following information):
Additional context
I found this bug investigating #6061. So, the given autocomplete config may not work anyway, but at least should bo provided to the Search component.
The text was updated successfully, but these errors were encountered: