External wc-admin/components work/questions

[jconroy]

This is purely a running collection of open questions and changes/adjustments to wc-admin (or wp components) we need to look at relevant for the project.

(Feel free to update - if we really need stuff we'll need help make it happen)

Marketing labeled issues

wc-admin

• New recommended way to fetch WC Admin settings - Provide a new API for consumers affected by settings breaking change woocommerce-admin#7802

woocommerce/components

• Could Report* components be added to components package? Could Report* components be added to components package? woocommerce-admin#6243
• wcadmin_analytics_filter events' value inconsistency wcadmin_analytics_filter events' value inconsistency woocommerce-admin#6237
• wcadmin_analytics_filter Tracking event is blind to variation filter changes. wcadmin_analytics_filter Tracking event is blind to variation filter changes. woocommerce-admin#6221
• @woocommerce/components dependency breaks tests for external plugins @woocommerce/components dependency breaks tests for external plugins woocommerce-admin#6483
• FilterPicker does not forward all props to Search component FilterPicker does not forward all props to Search component woocommerce-admin#6062
• CompareFilter does not forward autocompleter setting to the Search CompareFilter does not forward autocompleter setting to the Search  woocommerce-admin#6890
• Search component does not accept static options Array in autocomplete Search component does not accept static options Array in autocomplete woocommerce-admin#6061
• We workaround Chart to hide the legend, by setting legendPosition: 'hidden'. We should secure that as a feature. legendPosition: 'hidden' warning on the report pages #618
• WC<Link type="external"> is inconsistent with WP <ExternalLink> WC<Link type="external"> is inconsistent with WP <ExternalLink> woocommerce#32236

Woo

@woocommerce/e2e-utils

• test example/ mock for Jetpack connection [E2E] Add new test(s) that connect to Jetpack woocommerce#25741
  Required to make e2e test for GLA onboarding.

@woocommerce/e2e-environment

• Log WC version number when running wc-e2e docker:up Log WC version number when running wc-e2e docker:up woocommerce#30687
  Usefull for testing against multiple versions, checking compatibility, etc.

[tomalec]

@jconroy I wonder whether it's much value with tracking here all those issues. Given our sweet dependency hell (pb0Spc-1LK-p2), AKA:

• we support a range of WP & WC versions
• which comes with a range of individual versions
• we don't know which versions are delivered with WC
• sometimes it's not even a released version, but a specific commit from branch WC-admin release uses unreleased version of packages, making plugins unable to test against specific version of WC. woocommerce-admin#7628

the fact that the upstream issue was solved is far from making a change for us.

Also, as the external repose does not mention in which version the PR will be released it requires even more manual scavenging whether we can remove our workaround or not.

[tomalec]

I'm closing the issue, as I believe all the external issues are covered/ worked around to a sufficient extent.

I believe for any future issue, we can create an issue in an external repo, then add a link in a code comment in our code-base, close to the workaround, so it could be easily revisited later and removed if no longer needed.