-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect Programs filter to data source. #537
Conversation
Create `ProgramsReportFilters` to use customized `ReportsFilter`, that will use Date, Programs, and Compare filters consistently with other wc-admin analytics. Provide custom autocompleter for programs. Implements part of #242.
Hey @tomalec just confirming, are you saying we'll need a specific version of wc-admin (that hasn't been released yet?) If so, and if I understand correctly, I think we'll need to probably come up with our own component with fixes so that we can support them now |
Unfortunately, yes :| WDYT, of adding the copies of those fixed component files to |
a5c494e
to
ca95e7e
Compare
I added the clones to This adds some noise to this PR's diff, and
|
ca95e7e
to
feaff09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing well and LGTM.
Changes proposed in this Pull Request:
Create
ProgramsReportFilters
to use customizedReportsFilter
, that will use Date, Programs, andCompare filters consistently with other wc-admin analytics.
Provide custom autocompleter for programs.
Implements part of #242.
CompareFilter
does not forwardautocompleter
setting to theSearch
CompareFilter
does not forwardautocompleter
setting to theSearch
woocommerce-admin#6890FilterPicker does not forward all props to Search component woocommerce-admin#6062
Screenshots:
Review hints:
Changes to our components are in the first two commits https://github.com/woocommerce/google-listings-and-ads/pull/537/files/16728a6465480a81cc5a599da67fe1fcbebfe931
The others are importing unreleased wc-admin fixes: https://github.com/woocommerce/google-listings-and-ads/pull/537/files/16728a6465480a81cc5a599da67fe1fcbebfe931..feaff0901cb3997a6bda7e99773741e205756208
Detailed test instructions:
To be done in a separate PR:
Fix initial state. When you refresh the page or visit URL for the first time with programs chosen, the labels are not shown. This seems to ba another wc-admin issue, as
CompareFilter
&FilterPicker
seems to ignore changinggetLabels
function (it updates labels, only when params changes)When "Freee Listings" are chosen as a "single program", their label is not rendered. Probably because
FilterPicker
considers the selected option withid==0
the lack of selection.Changelog Note: