This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
CompareFilter
does not forward autocompleter
setting to the Search
#6890
Labels
Comments
12 tasks
tomalec
added a commit
that referenced
this issue
Apr 29, 2021
Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided. Fixes: #6890
This was referenced Apr 29, 2021
tomalec
added
focus: components
Issues for woocommerce components
focus: marketing
Related to Marketing Features
labels
Apr 30, 2021
tomalec
added a commit
that referenced
this issue
May 13, 2021
- Forward `autocompleter` prop from `CompareFilter` to `Search`. Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided. - Move `path` in Storybooks example to a parameter, to allow setting it in unit tests. - Add few tests for FilterPicker. - it renders the basic storybook example without throwing an error - it forwards `autocompleter` & `type` props Fixes: #6890
tomalec
added a commit
to woocommerce/google-listings-and-ads
that referenced
this issue
May 20, 2021
as those fixes were released in `@woocommerce/components`: - woocommerce/woocommerce-admin#6890, - woocommerce/woocommerce-admin#6062
tomalec
added a commit
to woocommerce/google-listings-and-ads
that referenced
this issue
Nov 25, 2021
as those fixes were released in `@woocommerce/components`: - woocommerce/woocommerce-admin#6890, - woocommerce/woocommerce-admin#6062 Remove no longer needed dependencies.
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this issue
Mar 18, 2022
…merce/woocommerce-admin#6911) - Forward `autocompleter` prop from `CompareFilter` to `Search`. Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided. - Move `path` in Storybooks example to a parameter, to allow setting it in unit tests. - Add few tests for FilterPicker. - it renders the basic storybook example without throwing an error - it forwards `autocompleter` & `type` props Fixes: woocommerce/woocommerce-admin#6890
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Describe the bug
This is similar to the problem with
FilterPicker
#6062I'm trying to set up a
<ReportFilters>
with a custom type of options to be chosen. I'm not able to, as for custom type I have to provideautocompleter
to the<Search>
component, but<CompareFilter>
does not forward this config. That results inTo Reproduce
Steps to reproduce the behavior:
<ReportFilters>
or<CompareFilter>
with settings that contains a custom type.Expected behavior
The component should render, with a specified autocompleter.
Screenshots
blank screen
Desktop (please complete the following information):
Smartphone (please complete the following information):
n/a
Additional context
It seems that the entire path of using any
*Filter*
component for atype
other than predefined ('attributes', 'categories', 'countries', 'coupons', 'customers', 'downloadIps', 'emails', 'orders', 'products', 'taxes', 'usernames', 'variableProducts', 'variations'
) is pretty abandoned.Maybe it's worth revisiting it as a whole, no just bug-by-bug. I noticed there are some bits of code that seems to serve custom usage, but also there are some non-WP/autocompleter -compliant properties in filters config, that is not fully explained in the docs, so I'm not sure what should I stick to when adding my own options to the filter.
As an external developer using
FilterPicker
orCompareFilter
I was thinking that having already loaded a finite list of options would make it really straightforward to configure those components to use it. But it already took me few days trying to figure out and reverse-engineer, what additional functions, and promises I need to provide in the config, what those function should return, what promises should resolve with.The text was updated successfully, but these errors were encountered: