Feature/3 create react version #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 9, 2019 15:04
I.e. `npm install --save-dev rollup-plugin-postcss`
Also, allow `groupLabel` in `OptionList` to generate more reliable ID.
I.e. Integrate `rollup-plugin-postcss`
- `tagName` - `className` - `fieldClassName`
Seems ineffectual, but only because of an implicit display as flex item.
- Extract `c-toggle` component. - Distinguish card sub-components from extracted modular components. - Remove duplicate application of `markupAttrs`. - Add `react/components/README.md`.
added 25 commits
October 16, 2019 17:28
- Rename `page--index` to `page--react|plain|index`. - Split NPM script `build:styles` into `plain` and `shared`. - Update `plain.html` markup. - Add `plain`-specific `c-media-output` styles.
Keep using `data-value` for `plain/`.
- Do not preserve filename comment for file that has only comments. - Add preserved filename comment for file that has styles.
- Add TODO to directly add class names. - Add new service `markup` with function `joinClassnames`. - Update `Gallery` to directly add class names.
- Remove TODO for this task. - Add unused class `c-card__attr` for consistency. - Add TODO for `joinClassNames` service. - Use `joinClassNames` service liberally. - Use `defaultProps` for `(c|…ClassName` values. - Move around some attributes in markup.
- Use `tagName: TagName = React.Fragment` in props deconstruction. - Use `tagAttrs` to only apply `className` if `props.tagName` exists. - In markup, move `className` next to `id` if there is space. - Use one `childClassName` instead of many `className`'s. - Update JSDoc to explain when a `props.(c|…C)lassName` is additional. - Use `joinClassNames` where it should be used (forgot in last commit). - Move around markup attribtues to read more easily.
- Use service consistently. - Add `console.debug` to log using provided ID, also. - Update TODO for it to consider how to further simplify or abstract.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #3.