Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create React Version #3

Closed
wesleyboar-fka-iosulfur opened this issue Sep 26, 2019 · 4 comments
Closed

Create React Version #3

wesleyboar-fka-iosulfur opened this issue Sep 26, 2019 · 4 comments
Assignees
@wesleyboar-fka-iosulfur
Labels
enhancement New feature or request

Comments

@wesleyboar-fka-iosulfur
Copy link
Collaborator

wesleyboar-fka-iosulfur commented Sep 26, 2019 •
edited
Loading

Create a version of this in React components (use minimal non-bundler setup).
Open
@wesleyboar-fka-iosulfur wesleyboar-fka-iosulfur added the enhancement New feature or request label Sep 30, 2019
Closed
@wesleyboar-fka-iosulfur
Copy link
Collaborator Author

wesleyboar-fka-iosulfur commented Oct 6, 2019 •
edited
Loading

PR #10 brings breaking changes to the parent branch. Update relevant code changes on this issue to adopt and work within the new infrastructure:

  • package dependency
  • move files i.e. source vs. public vs. built files, and update paths
  • component CSS included via JavaScript
  • configure build to support native and react pages

Merged
@wesleyboar-fka-iosulfur
Copy link
Collaborator Author

wesleyboar-fka-iosulfur commented Oct 9, 2019 •
edited
Loading

React version is available in the branch epic/1-compare-component-libraries (see PR #11), but the build process is coupled to the needs of React. Issue #9 is re-opened to resolve this. Then I'll return to finishing this issue.

@wesleyboar-fka-iosulfur
Copy link
Collaborator Author

Issue #9 is resolved (via PR #12 ). I am back on this issue.

Merged
@wesleyboar-fka-iosulfur
Copy link
Collaborator Author

Merged in PR #14!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesleyboar-fka-iosulfur wesleyboar-fka-iosulfur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wesleyboar-fka-iosulfur