Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3 create react version #14

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
1064328
Quick: Return intro to HTML. Rename app root.
Oct 9, 2019
6001510
Noop: Drop an unnecessary TODO.
Oct 9, 2019
1b2bbcc
Noop: Move type definitions to scripts directory
Oct 9, 2019
9ea9cf6
Quick: Install CSS plugin for JS bundler
Oct 11, 2019
a17ca7f
3: Convert `react-helpers` to `id` service
Oct 11, 2019
1afce70
Quick: Support PostCSS during JavaScript import
Oct 11, 2019
6319f26
Noop: Remove comment and add space
Oct 11, 2019
7cd4aa9
3: Add optional props to `AttributeInput`
Oct 11, 2019
18a5803
3: Add/Load `c-attr-input`/`AttributeInput` styles
Oct 11, 2019
b1bc106
3: Add `components/gallery.css` & `Gallery.js`
Oct 11, 2019
6cedd70
Quick: Remove `c-card__attr-…` excess specificity
Oct 11, 2019
17763f4
Quick: Adopt a "normalize" style into our styles
Oct 11, 2019
0e952cc
Major: New usage of <Gallery> & <AttributeInput>
Oct 11, 2019
ba6b105
Noop: Fix default values for prop in JSDoc comment
Oct 11, 2019
86f9f07
3: Extract `Wrapped/ElementList` from `Gallery`
Oct 11, 2019
03e2367
Noop: Move
Oct 11, 2019
8cfefba
Noop: Move comment to relevant line
Oct 11, 2019
abc6112
Quick: Rename variable
Oct 11, 2019
ecdd768
FIx: DOM updates for components using <Select>
Oct 11, 2019
a7da8ba
3: Fix <Gallery>/<AttributeInput> `tagName` logic
Oct 11, 2019
deb3757
Noop: Simplify JSDoc comments
Oct 11, 2019
898ec51
Quick: Remove unused variable
Oct 11, 2019
f704011
Quick: Move TODO (relevant logic recently moved)
Oct 11, 2019
80b4500
3: Use `React.Children.map` for safety
Oct 11, 2019
3cfd395
Noop: Add new TODO
Oct 11, 2019
d06d00f
Noop: Fix typo in TODO
Oct 12, 2019
67c65ba
Quick: Prepend `attr-input` and `gallry` CSS files
Oct 14, 2019
512c87b
3: Update "plain" version to use new component CSS
Oct 14, 2019
d7eb60c
WIP: Extract "toggle" component
Oct 14, 2019
8fe81d9
3: Extract "toggle" component
Oct 16, 2019
9f825aa
Quick: Add new lines and move style import
Oct 16, 2019
e3979e7
3: Extract component CSS for `c-intro`.
Oct 17, 2019
6656fa3
Noop: Add special CSS comment to component files
Oct 17, 2019
5fa6457
Noop: Add TODO about nonfunctional NODE_ENV
Oct 17, 2019
d83888c
3: Rename `components.css`→`components/c-card.css`
Oct 17, 2019
2ca9004
Noop: Add back-references to new issue #13
Oct 17, 2019
f6a4f18
3: Extract `c-media-output` and `MediaOutput`
Oct 17, 2019
bd94696
3: Update `plain` to use `c-media-output`
Oct 17, 2019
56a8092
3: Use `data-element` for `react/`
Oct 18, 2019
1ff0c82
Noop: CSS comment fixes
Oct 18, 2019
0e11132
Quick: Remove unnecessary CSS nesting
Oct 18, 2019
40f5dcb
3: Directly add `c-` class names (not pass 'em in)
Oct 18, 2019
061203d
Noop: Comments and spacing in `c-card.css`
Oct 18, 2019
6c24d44
3: Assign class names directly for `Toggle`
Oct 18, 2019
40fca64
3: Apply component-specific class names directly
Oct 18, 2019
c6600ae
3: Consistent use of `tagName` and `className`
Oct 18, 2019
a214397
Quick: Prefer `key` over `id` in `…ElementList`
Oct 18, 2019
3fb5126
Quick: Remove debug attribute from `Select`
Oct 18, 2019
4fad755
Quick: Fix console log level in `ShapeInput`
Oct 18, 2019
68eeb86
Noop: Add more TODOs
Oct 18, 2019
957ca80
Quick: Swap TODO `id`→`fieldId` w/ `_shared/data`
Oct 18, 2019
d177b83
3: Cleanup use of `idService` to be conistent
Oct 18, 2019
c06fcb8
Noop: Update top-of-file comment
Oct 19, 2019
6e60cfd
Noop: Remove copy-pasta comment
Oct 19, 2019
dd513ec
Noop: Comment rewrites
Oct 19, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
- TODO: Migrate component styles to React components.
- TODO: Split project into packages:
- parent `package.json` (shared code)
- children `package.json`'s (app-specific code)
- TODO: Move `_shared/` data files to `_shared/data`.
- TODO: Use [`PostHTML` tool](https://github.com/posthtml/posthtml) and [`htmlnano` plugin](https://github.com/posthtml/htmlnano).
- TODO: How to simplify or abstract the overhead of `idService.create`? Once solved, how to use…
- `useKeyGen` "custom hook"
- `@keyGen` decorator
- `ComponentName.keyGen` property (like `propTypes` or `defaultTypes`)
- TODO: Create test cases for each component.
- See [Testing Recipies #Rendering - React](https://reactjs.org/docs/testing-recipes.html#rendering)
- React: See [Testing Recipies #Rendering - React](https://reactjs.org/docs/testing-recipes.html#rendering)
- TODO: Test tree-shaking for React (i.e. a third-party CommonJS library):
- SEE: https://github.com/rollup/rollup-plugin-commonjs
- SEE: https://stackoverflow.com/questions/46575721/rollup-with-commonjs-import-and-exports-with-treeshaking
- SEE: https://stackoverflow.com/questions/48341175/how-does-webpack-bundler-resolves-named-import
- If it works, then use `{ thingFromReact }` instead of `React` when importing.
Loading