Node allow uncovered slots cscan #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
7 times, most recently
from
dfa092e to
c7b68f0
Compare
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
2 times, most recently
from
05aaab1 to
9c6b040
Compare
eifrah-aws
requested changes
Dec 17, 2024
6 tasks
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
2 times, most recently
from
a42b9ec to
2dec9d0
Compare
eifrah-aws
approved these changes
Dec 19, 2024
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
4 times, most recently
from
e0b2e32 to
2b772ab
Compare
Signed-off-by: avifenesh <[email protected]>
Signed-off-by: avifenesh <[email protected]>
Signed-off-by: jhpung <[email protected]>
Signed-off-by: jhpung <[email protected]>
…rClient Signed-off-by: avifenesh <[email protected]>
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
from
2b772ab to
a844c88
Compare
… option Signed-off-by: avifenesh <[email protected]>
avifenesh
force-pushed
the
Node@allow-ucslots-Cscan
branch
from
57c2c6c to
6518cf3
Compare
…in scan tests Signed-off-by: avifenesh <[email protected]>
6 tasks
yipin-chen
pushed a commit
that referenced
this pull request
Dec 24, 2024
* addresed comments Signed-off-by: avifenesh <[email protected]> * Go: add allow_non_covered_slots to ClusterScan and related commands Signed-off-by: avifenesh <[email protected]> * feat: Implement continuous slot scanning until next unscanned slot Signed-off-by: jhpung <[email protected]> * fix: improve slot scanning logic when address not found Signed-off-by: jhpung <[email protected]> * add allowNonCoveredSlots option to ScanOptions and update GlideClusterClient Signed-off-by: avifenesh <[email protected]> * test: add tests for GlideClusterClient scan with allowNonCoveredSlots option Signed-off-by: avifenesh <[email protected]> * refactor: enhance cluster readiness check and improve error handling in scan tests Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]> Signed-off-by: jhpung <[email protected]> Co-authored-by: jhpung <[email protected]> Signed-off-by: Yi-Pin Chen <[email protected]>
niharikabhavaraju
pushed a commit
to niharikabhavaraju/valkey-glide
that referenced
this pull request
Dec 29, 2024
* addresed comments Signed-off-by: avifenesh <[email protected]> * Go: add allow_non_covered_slots to ClusterScan and related commands Signed-off-by: avifenesh <[email protected]> * feat: Implement continuous slot scanning until next unscanned slot Signed-off-by: jhpung <[email protected]> * fix: improve slot scanning logic when address not found Signed-off-by: jhpung <[email protected]> * add allowNonCoveredSlots option to ScanOptions and update GlideClusterClient Signed-off-by: avifenesh <[email protected]> * test: add tests for GlideClusterClient scan with allowNonCoveredSlots option Signed-off-by: avifenesh <[email protected]> * refactor: enhance cluster readiness check and improve error handling in scan tests Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]> Signed-off-by: jhpung <[email protected]> Co-authored-by: jhpung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just node code, please check the last commit only.
For python and Rust please address in PR it rebased over.
Rebased over #2814
Adding uncovered slots cluster scan option to node
Issue link
This Pull Request is linked to issue #2689
Checklist
Before submitting the PR make sure the following are checked: