Core + Py: add allow_non_covered_slots to ClusterScan and related commands #2814

avifenesh · 2024-12-14T12:15:14Z

This pull request focuses on refactoring and simplifying the cluster_scan functionality in the glide-core/redis-rs library and adding allow non cover slots functionality to the core and py. Other important changes include removing redundant methods, consolidating the cluster_scan functions, and updating the related tests.

Refactoring and simplification:

glide-core/redis-rs/redis/src/cluster_async/mod.rs: Removed the cluster_scan_with_pattern method and consolidated its functionality into the cluster_scan method. Updated the cluster_scan method to use the ClusterScanArgs struct for arguments. [1] [2]
glide-core/redis-rs/redis/src/cluster_async/mod.rs: Removed redundant methods such as get_address_from_slot and check_if_all_slots_covered. Renamed methods for clarity, e.g., get_address_epoch to address_epoch and get_slots_of_address to slots_of_address. [1] [2] [3] [4]

Error handling improvements:

glide-core/redis-rs/redis/src/cluster_async/mod.rs: Enhanced error messages for better clarity when sending and receiving commands in the map_err and unwrap_or_else methods. [1] [2]

Test updates:

glide-core/redis-rs/redis/tests/test_cluster_scan.rs: Updated tests to use the new ClusterScanArgs struct and added tests for scanning with slot migration and handling missing slots. [1] [2] [3] [4] [5] [6] [7] [8]

These changes aim to streamline the codebase, improve error handling, and ensure the tests are up-to-date with the new functionality.

Issue link

This Pull Request is linked to issue #2436

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

raphaelauv · 2024-12-14T12:18:34Z

🎉

glide-core/redis-rs/redis/src/commands/cluster_scan.rs

Signed-off-by: avifenesh <[email protected]>

…an functionality Signed-off-by: avifenesh <[email protected]>

…ests Signed-off-by: avifenesh <[email protected]>

raphaelauv · 2024-12-22T11:44:05Z

@avifenesh 🥇

avifenesh · 2024-12-22T12:51:41Z

@raphaelauv we are hopefully going to release it as a patch this week.
Appreciate your patience!

…mands (valkey-io#2814) * added to core and python the option to scan uncoverd slots in a cluster Signed-off-by: avifenesh <[email protected]> * addresed comments Signed-off-by: avifenesh <[email protected]> * Refactor slot scanning logic and improve test coverage for cluster scan functionality Signed-off-by: avifenesh <[email protected]> * Refactor cluster readiness check and enhance scan error handling in tests Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]>

avifenesh requested a review from a team as a code owner December 14, 2024 12:15

avifenesh requested review from jhpung, barshaul and eifrah-aws December 14, 2024 12:15

avifenesh self-assigned this Dec 14, 2024

avifenesh added Feature Additional feature, big or small All Wrappers issue Issue relevant to all wrrappers. 1_2_1_candidate labels Dec 14, 2024

avifenesh added this to the 1.2.1 milestone Dec 14, 2024

avifenesh changed the title ~~Go: add allow_non_covered_slots to ClusterScan and related commands~~ Core + Py: add allow_non_covered_slots to ClusterScan and related commands Dec 14, 2024

avifenesh mentioned this pull request Dec 14, 2024

Node allow uncovered slots cscan #2815

Merged

5 tasks

avifenesh force-pushed the Feature-dummyScan branch 4 times, most recently from 0b0c077 to 85ddec0 Compare December 14, 2024 23:04

ikolomi removed this from the 1.2.1 milestone Dec 15, 2024

avifenesh force-pushed the Feature-dummyScan branch 4 times, most recently from c4156b2 to 29024eb Compare December 18, 2024 11:37