-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Allow uncovered slots ClusterScan #2859
Java: Allow uncovered slots ClusterScan #2859
Conversation
Due to the fact that we can't create/stop valkey clusters in the middle of a Java test, and because the testing of this feature requires dedicated cluster with special configuration, the automatic test is not included in this PR. Created Issue #2860 to track the progress of implementing the ability to create/terminate cluster in the middle of a Java test. Will finish CI testing of this feature afterwards. I've done test locally and the result is expected. |
@@ -28,6 +29,13 @@ public class ScanOptions extends BaseScanOptions { | |||
*/ | |||
private final ObjectType type; | |||
|
|||
/** | |||
* If set to True, the scan will perform even if some slots are not covered by any node. It's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* If set to True, the scan will perform even if some slots are not covered by any node. It's | |
* If set to true, the scan will perform even if some slots are not covered by any node. It's |
Also next line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much a nitpick, just some grammar things:
- "If set to true, the scan will proceed/be performed/be executed even if..."
- "However, it is important to note that in this mode, the scan cannot guarantee coverage of all keys in the cluster and it loses the ability to validate its progress"
Up to you if you want to adopt any of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after minor comment update.
If possible, can you please provide manual testing steps?
java/client/src/main/java/glide/api/models/commands/scan/ScanOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
5b7346d
to
bd14a78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we need to freeze this PR until we can run tests for this feature in CI.
Co-authored-by: tjzhang-BQ <[email protected]> Signed-off-by: James Xin <[email protected]>
I have asked James to create an issue to track the missing capability for cluster creation in Java. As discussed in this morning's sync-up meeting, we will merge this PR with proof of manual testing. |
Signed-off-by: James Xin <[email protected]>
Java: Allow uncovered slots ClusterScan --------- Signed-off-by: James Xin <[email protected]> Co-authored-by: tjzhang-BQ <[email protected]>
Java: Allow uncovered slots ClusterScan --------- Signed-off-by: James Xin <[email protected]> Co-authored-by: tjzhang-BQ <[email protected]>
Java: Allow uncovered slots ClusterScan --------- Signed-off-by: James Xin <[email protected]> Co-authored-by: tjzhang-BQ <[email protected]> Signed-off-by: BoazBD <[email protected]>
Issue link
This Pull Request is linked to issue (URL): #2436
Checklist
Before submitting the PR make sure the following are checked: