Node: fix imports

[acarbonetto]

Issue link

This Pull Request is linked to issue (URL): #2335

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one issue.
• Commit message has a detailed description of what changed and why.
• Tests are added or updated.
• CHANGELOG.md and documentation files are updated.
• Destination branch is correct - main or release
• Commits will be squashed upon merging.

[acarbonetto]

UpdateOptions doesn't exist in Commands.ts (renamed to UpdateByScore I believe)

[acarbonetto]

Replaced with BaseScanOptions

[acarbonetto]

SortedSetRange is not exported

valkey-glide/node/src/Commands.ts

Line 1731 in d75a21e

interface SortedSetRange<T> {

[acarbonetto]

internal function

valkey-glide/node/src/Commands.ts

Line 59 in d75a21e

export function parseInfoResponse(response: string): Record<string, string> {

[acarbonetto]

used by scan

valkey-glide/node/src/GlideClient.ts

Line 1109 in d75a21e

public async scan(

[acarbonetto]

Used by FT Create

valkey-glide/node/src/server-modules/GlideFtOptions.ts

Line 111 in d75a21e

export type Field = TextField | TagField | NumericField | VectorField;

[prateek-kumar-improving]

Ran the test again. Below symbols are missing for export:
[
'BaseClient',
'BaseTransaction',
'Field',
'ScanOptions',
'VectorFieldAttributes',
'convertFieldsAndValuesToHashDataType'
]

Field and ScanOptions are added.
We can make convertFieldsAndValuesToHashDataType as internal. Maybe VectorFieldAttributes also.
Why do BaseClient and BaseTransaction are not included in the export?

[Yury-Fridlyand]

Why do BaseClient and BaseTransaction are not included in the export?

Users should use derived classes only (standalone/cluster)

[acarbonetto]

Why do BaseClient and BaseTransaction are not included in the export?

Good question. Because a user will never need them. BaseClient and BaseTransaction are 'abstract' classes that will never be used by a user and should not be exposed. Users can create unions of types if they need wider typing.

In a separate PR, we can make these classes private and not expose them.

[acarbonetto]

Ran the test again. Below symbols are missing for export: [ 'BaseClient', 'BaseTransaction', 'Field', 'ScanOptions', 'VectorFieldAttributes', 'convertFieldsAndValuesToHashDataType' ]

• BaseClient, BaseTransaction are not needed.
• Field, and ScanOptions are added in this PR.
• VectorFieldAttributes is also not needed.
• convertFieldsAndValuesToHashDataType is an internal PR and should be marked as such.

The above will be cleaned up under #2721

[prateek-kumar-improving]

A list of exports that are not in the source code:
[
'ClusterScanCursor',
'FtProfileOtions',
'Script',
'SortClusterOptions',
'SortedSetRange',
'UpdateOptions',
'createLeakedArray',
'createLeakedAttribute',
'createLeakedBigint',
'createLeakedDouble',
'createLeakedMap',
'createLeakedString',
'default',
'parseInfoResponse'
]
parseInfoResponse, ClusterScanCursor, SortedSetRange, UpdateOptions, FtProfileOtions are removed. What about script and default?
Some of these are part of the glide-rs package. Is there a need for our package to export something from another package?

• ClusterScanCursor, and Script are part of glide-rs and are being exported. We should attempt to fix this in Node: Check API exports symbols #2721.
• FtProfileOtions, SortedSetRange, UpdateOptions are fixed by this PR (see comments)
• create* are test-only functions and don't need to be exported to the end user. I've added the internal flag on Node: Check API exports symbols #2721.
• same with parseInfoResponse.
• default is a false positive (see npm/glide/index.ts) - and we should try and fix that false-positive on Node: Check API exports symbols #2721 somehow.