Node: Check API exports symbols #2721

prateek-kumar-improving · 2024-11-20T13:03:01Z

Issue link

This Pull Request is linked to issue (URL): #2335

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Commits will be squashed upon merging.

Signed-off-by: Prateek Kumar <[email protected]>

* Revert "Python: add AZ Affinity ReadFrom strategy Support (#2676)" This reverts commit 4d33f95. * removed unessesrry import * add Unicode-3.0 license --------- Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>

* Python: rename glide json Signed-off-by: Shoham Elias <[email protected]> --------- Signed-off-by: Shoham Elias <[email protected]>

* Added AZAffinity strategy to Node.js --------- Signed-off-by: Muhammad Awawdi <[email protected]>

* Python: add AZAffinity ReadFrom strategy --------- Signed-off-by: BoazBD <[email protected]> Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: BoazBD <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>

* Java: AZ awareness Signed-off-by: TJ Zhang <[email protected]>

* Add password update API Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: prateek-kumar-improving <[email protected]>

nit: removed comments Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>

#2705)

--------- Signed-off-by: Muhammad Awawdi <[email protected]>

============================================== Signed-off-by: Muhammad Awawdi <[email protected]>

* Java: adding changelog for java az support change Signed-off-by: TJ Zhang <[email protected]>

* Update Node.js Docker image and enhance npm publish workflow with unpublish feature Signed-off-by: avifenesh <[email protected]> * unpublishing a package owned by more than one cant be unpublised, hence the usage is deprecating Signed-off-by: avifenesh <[email protected]> --------- Signed-off-by: avifenesh <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix readme Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Prateek Kumar <[email protected]>

Signed-off-by: Andrew Carbonetto <[email protected]>

Signed-off-by: Prateek Kumar <[email protected]>

Signed-off-by: Andrew Carbonetto <[email protected]>

prateek-kumar-improving · 2024-11-27T02:00:14Z

This PR also addresses the comments and pending items as mentioned in this PR: #2767

acarbonetto · 2024-11-27T02:01:32Z

TODOs for this PR:

Properly check rust-client imports. Ensure that rust-client d.ts definitions are being exported with the module.
Why are we copying d.ts build artefacts into the releasable module? they should be available as dependencies... something to fix? Should we also be copying the rust-client definitions (and isn't there a name conflict then?)
Add npm/glide testse to node CI to be run on all PRs.

Signed-off-by: Prateek Kumar <[email protected]>

Node: Check exports

353410b

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving requested review from Yury-Fridlyand and acarbonetto November 20, 2024 13:03

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 20, 2024 13:03 — with GitHub Actions Error

Yury-Fridlyand added the node Node.js wrapper label Nov 20, 2024

Node: Get all .ts file names

2039066

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 21, 2024 17:42 — with GitHub Actions Error

Node: code cleanup

07b96df

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 21, 2024 17:57 — with GitHub Actions Error

Node: code cleanup

6c74411

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 21, 2024 18:30 — with GitHub Actions Error

acarbonetto changed the title ~~Node: Check exports~~ Node: Check API exports symbols Nov 22, 2024

avifenesh mentioned this pull request Nov 24, 2024

Release 1.2 GA #2746

Closed

15 tasks

Node: find missing symbols

7bda107

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 25, 2024 19:54 — with GitHub Actions Error

adarovadya and others added 15 commits November 25, 2024 17:29

Python: rename glide json (#2702)

9111740

* Python: rename glide json Signed-off-by: Shoham Elias <[email protected]> --------- Signed-off-by: Shoham Elias <[email protected]>

Node: add AZ Affinity ReadFrom strategy Support (#2686)

9c26a5b

* Added AZAffinity strategy to Node.js --------- Signed-off-by: Muhammad Awawdi <[email protected]>

Java: AZ Awareness (#2678)

07e55c6

* Java: AZ awareness Signed-off-by: TJ Zhang <[email protected]>

Java: Add password update API (#2677)

e19e500

* Add password update API Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: prateek-kumar-improving <[email protected]>

Python: nit fix (#2726)

6e94ff3

nit: removed comments Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>

Allow user to set different logging directory by passing environment … (

cb2525b

#2705)

Node - Client API for retrieving internal statistics (#2727)

417369a

--------- Signed-off-by: Muhammad Awawdi <[email protected]>

Decrease Warnings in the CI (#2703)

62686e1

============================================== Signed-off-by: Muhammad Awawdi <[email protected]>

Java: adding changelog for java az support change (#2734)

cb9ce08

* Java: adding changelog for java az support change Signed-off-by: TJ Zhang <[email protected]>

Fix node scripts and docs. (#2744)

6fa46eb

Signed-off-by: Yury-Fridlyand <[email protected]>

Java: Fix readme (#2751)

7123a68

* Fix readme Signed-off-by: Yury-Fridlyand <[email protected]>

fix changelog (#2752)

ebd33c5

Signed-off-by: Yury-Fridlyand <[email protected]>

Node: check exports

bcae875

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 26, 2024 01:30 — with GitHub Actions Failure

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 26, 2024 01:30 — with GitHub Actions Error

Merge branch 'release-1.2' into node-exports-check

90a1d43

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 26, 2024 01:44 — with GitHub Actions Error

Node package.json updated

0e7d169

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 26, 2024 01:49 — with GitHub Actions Error

Node: add API test for glide release package

cbf93a8

Signed-off-by: Andrew Carbonetto <[email protected]>

acarbonetto had a problem deploying to AWS_ACTIONS November 26, 2024 22:19 — with GitHub Actions Error

Fix build script

385bbae

Signed-off-by: Andrew Carbonetto <[email protected]>

acarbonetto had a problem deploying to AWS_ACTIONS November 26, 2024 22:41 — with GitHub Actions Error

Node: Update loadNativeBinding() in index.ts

a48d8b8

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 27, 2024 01:28 — with GitHub Actions Error

Additional cleanup for Node package builder

0232cc8

Signed-off-by: Andrew Carbonetto <[email protected]>

acarbonetto had a problem deploying to AWS_ACTIONS November 27, 2024 01:45 — with GitHub Actions Error

acarbonetto mentioned this pull request Nov 27, 2024

Node: fix imports #2767

Merged

6 tasks

Node: branch rebased

10cf60d

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 27, 2024 02:14 — with GitHub Actions Error

Node: update list type

d88e21a

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS November 27, 2024 02:16 — with GitHub Actions Error

prateek-kumar-improving changed the base branch from release-1.2 to main December 10, 2024 21:45

Merge branch 'main' into node-exports-check

94212bf

prateek-kumar-improving had a problem deploying to AWS_ACTIONS December 10, 2024 21:45 — with GitHub Actions Error

Resolve merge conflicts

7cc2b1a

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving requested a deployment to AWS_ACTIONS December 10, 2024 21:54 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node: Check API exports symbols #2721

Node: Check API exports symbols #2721

prateek-kumar-improving commented Nov 20, 2024 •

edited

Loading

prateek-kumar-improving commented Nov 27, 2024

acarbonetto commented Nov 27, 2024

Node: Check API exports symbols #2721

Are you sure you want to change the base?

Node: Check API exports symbols #2721

Conversation

prateek-kumar-improving commented Nov 20, 2024 • edited Loading

Issue link

Checklist

prateek-kumar-improving commented Nov 27, 2024

acarbonetto commented Nov 27, 2024

prateek-kumar-improving commented Nov 20, 2024 •

edited

Loading