Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: fix imports #2767

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Node: fix imports #2767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions node/npm/glide/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ function initialize() {
const {
AggregationType,
BaseScanOptions,
ScanOptions,
ZScanOptions,
HScanOptions,
BitEncoding,
Expand Down Expand Up @@ -119,6 +120,7 @@ function initialize() {
GlideClientConfiguration,
GlideJson,
GlideFt,
Field,
TextField,
TagField,
NumericField,
Expand All @@ -138,7 +140,6 @@ function initialize() {
FtAggregateApply,
FtAggregateReturnType,
FtSearchReturnType,
FtProfileOtions,
Yury-Fridlyand marked this conversation as resolved.
Show resolved Hide resolved
GlideRecord,
GlideString,
JsonGetOptions,
Expand Down Expand Up @@ -175,16 +176,13 @@ function initialize() {
InfBoundary,
KeyWeight,
Boundary,
UpdateOptions,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UpdateOptions doesn't exist in Commands.ts (renamed to UpdateByScore I believe)

ProtocolVersion,
RangeByIndex,
RangeByScore,
RangeByLex,
ReadFrom,
ServerCredentials,
SortClusterOptions,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with BaseScanOptions

SortOptions,
SortedSetRange,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SortedSetRange is not exported

valkey-glide/node/src/Commands.ts

Line 1731 in d75a21e

interface SortedSetRange<T> {

StreamGroupOptions,
StreamTrimOptions,
StreamAddOptions,
Expand Down Expand Up @@ -215,7 +213,6 @@ function initialize() {
createLeakedDouble,
createLeakedMap,
createLeakedString,
parseInfoResponse,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal function

valkey-glide/node/src/Commands.ts

Line 59 in d75a21e

export function parseInfoResponse(response: string): Record<string, string> {

Script,
ObjectType,
ClusterScanCursor,
Expand All @@ -233,6 +230,7 @@ function initialize() {
module.exports = {
AggregationType,
BaseScanOptions,
ScanOptions,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used by scan

valkey-glide/node/src/GlideClient.ts

Line 1109 in d75a21e

public async scan(

HScanOptions,
ZScanOptions,
BitEncoding,
Expand All @@ -253,6 +251,7 @@ function initialize() {
DecoderOption,
GeoAddOptions,
GlideFt,
Field,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used by FT Create

valkey-glide/node/src/server-modules/GlideFtOptions.ts

Line 111 in d75a21e

export type Field = TextField | TagField | NumericField | VectorField;

TextField,
TagField,
NumericField,
Expand All @@ -272,7 +271,6 @@ function initialize() {
FtAggregateApply,
FtAggregateReturnType,
FtSearchReturnType,
FtProfileOtions,
GlideRecord,
GlideJson,
GlideString,
Expand Down Expand Up @@ -326,16 +324,13 @@ function initialize() {
InfBoundary,
KeyWeight,
Boundary,
UpdateOptions,
ProtocolVersion,
RangeByIndex,
RangeByScore,
RangeByLex,
ReadFrom,
ServerCredentials,
SortClusterOptions,
SortOptions,
SortedSetRange,
StreamGroupOptions,
StreamTrimOptions,
StreamAddOptions,
Expand Down Expand Up @@ -364,7 +359,6 @@ function initialize() {
createLeakedDouble,
createLeakedMap,
createLeakedString,
parseInfoResponse,
Script,
ObjectType,
ClusterScanCursor,
Expand Down
Loading