#39 Fix supported Python version #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JMTyndall
commented
Dec 2, 2024
JMTyndall
commented
- Close Fix supported Python version #39
- Completed all goals of Fix supported Python version #39.
- Updated dependencies.
mcsken
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Looks good. Tested locally, there is now no issues with dependencies reported by deptry and all tests pass as expected.
Passing for final review and to merge to @roskakori.
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
roskakori
requested changes
Dec 7, 2024
Accidentally forgot to remove cryptography from dev dependencies when I moved it to public dependencies with the original commit. This commit amends that.
roskakori
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.