Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix supported Python version #39

Closed
11 tasks done
roskakori opened this issue Nov 27, 2024 · 1 comment · Fixed by #41 or #43
Closed
11 tasks done

Fix supported Python version #39

roskakori opened this issue Nov 27, 2024 · 1 comment · Fixed by #41 or #43
Assignees
@JMTyndall
Labels
bug Something isn't working good first issue Good for newcomers improvement Does the same as before but better
Milestone
v1.1.0

Comments

@roskakori
Copy link
Contributor

roskakori commented Nov 27, 2024 •
edited by mcsken
Loading

Background

Currently the pyproject.toml claims 3.10. is supported, this should actually be 3.11.:

[tool.poetry.dependencies]
python = ">=3.10, <3.14"

Also while at it, several dependencies can also be cleaned up in the pyproject.toml.

Goals

Estimate: 1.5h

Implementation notes

Dependencies should be removed with poetry remove ... and added with poetry add ...
You can put dependencies in a dev group with poetry add ... --group dev
@roskakori roskakori added the bug Something isn't working label Nov 27, 2024
@roskakori roskakori added this to the v1.1.0 milestone Nov 27, 2024
@mcsken mcsken added the good first issue Good for newcomers label Nov 27, 2024
@mcsken mcsken self-assigned this Nov 27, 2024
@mcsken mcsken added the improvement Does the same as before but better label Nov 27, 2024
@mcsken mcsken removed their assignment Nov 27, 2024
JMTyndall added a commit to JMTyndall/check_done that referenced this issue Dec 2, 2024
@JMTyndall
siisurit#39 Update dependencies
a8b7359
JMTyndall added a commit to JMTyndall/check_done that referenced this issue Dec 2, 2024
@JMTyndall
siisurit#39 Fix supported Python version
21fa3f4
@JMTyndall JMTyndall mentioned this issue Dec 2, 2024
Merged
@JMTyndall
Copy link
Contributor

See #41

mcsken added a commit to JMTyndall/check_done that referenced this issue Dec 9, 2024
@mcsken
siisurit#39 Move cryptography to public dependencies
8483ee8
mcsken added a commit to JMTyndall/check_done that referenced this issue Dec 9, 2024
@mcsken
siisurit#39 Update dependencies
6887804
mcsken added a commit to JMTyndall/check_done that referenced this issue Dec 9, 2024
@mcsken
siisurit#39 Remove cryptography from dev dependencies
68d701b 
Accidentally forgot to remove cryptography from dev dependencies when I moved it to public dependencies with the original commit. This commit amends that.
roskakori added a commit that referenced this issue Dec 10, 2024
@roskakori
Merge pull request #41 from JMTyndall/39-fix-supported-python-version
e9d3b88 
#39 Fix supported Python version
roskakori added a commit that referenced this issue Dec 10, 2024
@roskakori
#39 Bump version and update changelog
04eb692
@roskakori roskakori mentioned this issue Dec 10, 2024
Merged
roskakori added a commit that referenced this issue Dec 10, 2024
@roskakori
Merge pull request #43 from siisurit/39-fix-supported-python-version
3c8b459 
#39 Bump version and update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JMTyndall JMTyndall

Labels
bug Something isn't working good first issue Good for newcomers improvement Does the same as before but better
Projects
None yet
Milestone
v1.1.0
3 participants
@roskakori @mcsken @JMTyndall