Fix supported Python version #40
Conversation
| from dotenv import load_dotenv | ||
| load_dotenv() |
There was a problem hiding this comment.
Can you explain why did you create a new test file that doesn't align with any module and that does nothing but load the environment variables?
This was not part of the requirements.
You mentioned in the PR "Ensure everything works by testing the environment", but nothing is being actually tested here. And no environment-variable-dependent test is needed to complete the requirements of this issue.
| pyyaml = "^6.0.2" | ||
| python-dotenv = "^1.0.1" | ||
| pytest-mock = "^3.14.0" | ||
| pydantic = "^2.10.2" | ||
| pyjwt = "^2.9.0" | ||
| requests-mock = "^1.12.1" |
There was a problem hiding this comment.
requests-mock should have been removed from the main dependencies when it was moved to dev dependencies.
| [tool.poetry.group.dev.dependencies] | ||
| cryptography = "^44.0.0" | ||
| requests-mock = "^1.12.1" | ||
| python-dotenv = "^1.0.1" | ||
|
|
There was a problem hiding this comment.
coverage, pytest, pytest-cov, pre-commit and ruff should have been migrated from the old-style dev dependencies group to the new one here, and the old dev dependencies section should have been as a result removed.
| @@ -19,7 +19,7 @@ repository = "https://github.com/siisurit/check_done.git" | |||
| documentation = "https://github.com/siisurit/check_done/blob/main/README.md" | |||
| keywords = ["check", "closed", "done", "done done", "finished", "issue", "task", "validate"] | |||
| classifiers = [ | |||
| "Development Status :: 4 - Beta", | |||
| "Development Status :: 4 - Beta", | |||
There was a problem hiding this comment.
The original indentation was correct, should be reverted.
| <content url="file://$MODULE_DIR$"> | ||
| <excludeFolder url="file://$MODULE_DIR$/.venv" /> | ||
| </content> | ||
| <orderEntry type="jdk" jdkName="Python 3.12 (check_done)" jdkType="Python SDK" /> |
There was a problem hiding this comment.
Contributors should either adhere to the project's IDE configuration by renaming the virtual environment used for the project to match the existing IDE project settings, or not commit this file. This should be reverted.
| rich = ">=9, <14" | ||
| gitpython = "^3" | ||
| python = ">=3.11, <3.14" | ||
|
|
There was a problem hiding this comment.
Unnecessary empty space, should be removed.
|
Rejecting in favor of the cleaner PR #41. |
Update Python Version in pyproject.toml
Remove Unused Dependencies
Add Missing Dependency (requests)
Migrate Dev Dependencies to the New Style
Ensure everything works by testing the environment
poetry run pytest