fix #138: [jaspr_riverpod] update vsyncOverride to flutterVsyncs #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Version ReportThe following packages have been updated: |
gadfly361
force-pushed
the
fix/issue-138/vsync-override
branch
2 times, most recently
from
7874fa2 to
92b0af8
Compare
gadfly361
force-pushed
the
fix/issue-138/vsync-override
branch
from
92b0af8 to
b9a437c
Compare
gadfly361
changed the title
schultek
requested changes
Nov 14, 2023
|
Hey, is there any issue with this PR? Or You can merge this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fix for #138.
In riverpod,
vsyncOverridewas removed in riverpod v2.4.6 (rrousselGit/riverpod#3072) and replaced withflutterVsyncs. This PR makes the same replacement in jaspr_riverpod.Type of Change
Ready Checklist
the semantic_changelog format.
///).If you need help, consider asking for advice on the #contribute channel on Discord.