fix: #138 migrate to flutterVsyncs instead of vsyncOverride

schultek · Nov 14, 2023 · b9a437c · b9a437c
1 parent 3495cfd
commit b9a437c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -5,4 +5,5 @@
 
 Kilian Schulte (schultek) - Creator & Lead Developer
 Martin Jablečník (mjablecnik) - Contributor
-Jeff Ward (fuzzybinary) - Contributor
+Jeff Ward (fuzzybinary) - Contributor
+Matthew Jaoudi (gadfly361) - Contributor
diff --git a/packages/jaspr_riverpod/CHANGELOG.md b/packages/jaspr_riverpod/CHANGELOG.md
@@ -1,3 +1,8 @@
+## Unreleased 0.3.8
+
+- Upgrade `riverpod` to `v2.4.6`
+- Update `jaspr_riverpod`'s dependency on `riverpod`'s `vsyncOverride` to `flutterVsyncs`
+
 ## 0.3.7
 
 - Fixed bug with SyncProvider.

diff --git a/packages/jaspr_riverpod/lib/src/framework.dart b/packages/jaspr_riverpod/lib/src/framework.dart
@@ -314,7 +314,7 @@ class _UncontrolledProviderScopeElement extends InheritedElement {
       debugCanModifyProviders ??= _debugCanModifyProviders;
     }
 
-    vsyncOverride ??= _jasprVsync;
+    flutterVsyncs.add(_jasprVsync);
     super.mount(parent, prevSibling);
   }
 
@@ -370,9 +370,7 @@ class _UncontrolledProviderScopeElement extends InheritedElement {
       debugCanModifyProviders = null;
     }
 
-    if (vsyncOverride == _jasprVsync) {
-      vsyncOverride = null;
-    }
+    flutterVsyncs.remove(_jasprVsync);
     super.unmount();
   }
 

diff --git a/packages/jaspr_riverpod/pubspec.yaml b/packages/jaspr_riverpod/pubspec.yaml
@@ -14,7 +14,7 @@ environment:
 dependencies:
   jaspr: ^0.9.0
   meta: ^1.9.1
-  riverpod: ^2.3.2
+  riverpod: ^2.4.6
 
 dev_dependencies:
   jaspr_test: '>=0.1.0 <1.0.0'