Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #138: [jaspr_riverpod] update vsyncOverride to flutterVsyncs #139

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix #138: [jaspr_riverpod] update vsyncOverride to flutterVsyncs #139

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a437c
fix: #138 migrate to flutterVsyncs instead of vsyncOverride
gadfly361 Nov 14, 2023
29a6c9a
retitle changelog
gadfly361 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@

Kilian Schulte (schultek) - Creator & Lead Developer
Martin Jablečník (mjablecnik) - Contributor
Jeff Ward (fuzzybinary) - Contributor
Jeff Ward (fuzzybinary) - Contributor
Matthew Jaoudi (gadfly361) - Contributor
5 changes: 5 additions & 0 deletions packages/jaspr_riverpod/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## Unreleased 0.3.8
gadfly361 marked this conversation as resolved.
Show resolved Hide resolved

- Upgrade `riverpod` to `v2.4.6`
- Update `jaspr_riverpod`'s dependency on `riverpod`'s `vsyncOverride` to `flutterVsyncs`

## 0.3.7

- Fixed bug with SyncProvider.
Expand Down
6 changes: 2 additions & 4 deletions packages/jaspr_riverpod/lib/src/framework.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ class _UncontrolledProviderScopeElement extends InheritedElement {
debugCanModifyProviders ??= _debugCanModifyProviders;
}

vsyncOverride ??= _jasprVsync;
flutterVsyncs.add(_jasprVsync);
super.mount(parent, prevSibling);
}

Expand Down Expand Up @@ -370,9 +370,7 @@ class _UncontrolledProviderScopeElement extends InheritedElement {
debugCanModifyProviders = null;
}

if (vsyncOverride == _jasprVsync) {
vsyncOverride = null;
}
flutterVsyncs.remove(_jasprVsync);
super.unmount();
}

Expand Down
2 changes: 1 addition & 1 deletion packages/jaspr_riverpod/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ environment:
dependencies:
jaspr: ^0.9.0
meta: ^1.9.1
riverpod: ^2.3.2
riverpod: ^2.4.6

dev_dependencies:
jaspr_test: '>=0.1.0 <1.0.0'
Expand Down