Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config.json consistent between shortfin and sharktank #487

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Make config.json consistent between shortfin and sharktank #487

wants to merge 9 commits into from

Commits on Nov 12, 2024

  1. the configs should be consistent now

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c0de8d2 View commit details
    Browse the repository at this point in the history

  2. remove config editing from integration test

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f8782de View commit details
    Browse the repository at this point in the history

  3. fix cache_test.py and paged_kv_unit_size_elements

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b4074bb View commit details
    Browse the repository at this point in the history

  4. remove attention_head_count (superceded by attention_head_count_kv)

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5ec2d10 View commit details
    Browse the repository at this point in the history

  5. typo

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b2c0291 View commit details
    Browse the repository at this point in the history

  6. add a type hint

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    93fa5a0 View commit details
    Browse the repository at this point in the history

  7. make cpu_llm_server_test grab the tokenizer config

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bc6701c View commit details
    Browse the repository at this point in the history

  8. fix config writing

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    98f7d12 View commit details
    Browse the repository at this point in the history

  9. add a docstring and remove a commented out line

    @renxida
    renxida committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c7b1d3b View commit details
    Browse the repository at this point in the history