Make config.json consistent between shortfin and sharktank #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbaione
reviewed
Nov 12, 2024
| return { | ||
| "module_name": "module", | ||
| "module_abi_version": 1, | ||
| "max_seq_len": hp.context_length, | ||
| "attn_head_count": hp.attention_head_count, | ||
| # "attn_head_count": hp.attention_head_count, # we don't need the attention head count we just need the kvcache attention head count for shortfin |
There was a problem hiding this comment.
Since all of the docs are updated and references to "attn_head_count" are removed, this is probably fine to delete. Otherwise, it'll sit here lingering for who knows how long
stbaione
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the adaption layer in buidl_tools/integration_tests/llm/conftest.py