-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci.yml to add support for loongarch64 #2461
Conversation
Add support for loongarch64
Please also add this. |
Any idea about this error?
|
|
Push MSRV to 1.71.0
@@ -13,7 +13,7 @@ permissions: | |||
contents: read | |||
|
|||
env: | |||
MSRV: 1.69.0 | |||
MSRV: 1.71.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not change the MSRV for an architecture, I think we should add a step that will overwrite the MSRV
environment variable to 1.71.0 when ${{ matrix.target }}
is loongarch64-unknown-linux-gnu
, something like:
- name: change Rust toolchain version for Loongarch
run: echo "MSRV=$(if [ '${{ matrix.target }}' = 'loongarch64-unknown-linux-gnu' ]; then echo '1.71.0'; else echo '${{ env.MSRV }}'; fi)" >> $GITHUB_ENV
Ok, I have no idea why it still does not work, it should work according to the cross doc:
|
cross-rs/cross@8c86a98, probably it should use a git-snapshot version |
I have rewrite a new config for Loongarch64 CI, and it works. Unfortunately, I face a big problem with the QEMU and testcases below. BTW, I guess some commits in QEMU can change some syscalls' behavior, that brings some weird test results... -> #2418 |
Close as this will be superseded by #2509. |
What does this PR do
Add CI support for loongarch64 (re-implementation of #2023 ). Ioctl has been implemented in #2045 .
Checklist:
CONTRIBUTING.md