Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI for Loongarch64 #2509

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Enable CI for Loongarch64 #2509

merged 2 commits into from
Sep 22, 2024

Conversation

Fearyncess
Copy link
Contributor

@Fearyncess Fearyncess commented Sep 21, 2024

What does this PR do

This PR is the reimplementation of PR #2461. That will enable CI testing for loongarch64-unknown-linux-gnu.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC
Copy link
Member

@Fearyncess:

I have rewrite Fearyncess#1 for Loongarch64 CI, and it works. Unfortunately, I face a big problem with the QEMU and testcases below.
Loongarch64 need a newer QEMU after 7.1 version. But before QEMU supported la64, qemu has a commit that has disabled many PRCTL subcodes 3 yrs ago. This commit will cause test_prctl failed in some cases, due to these subcodes has been disabled in newer QEMU.

BTW, I guess some commits in QEMU can change some syscalls' behavior, that brings some weird test results... -> #2418

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this target to the target support list of Nix as a tier2 target.

test/sys/test_prctl.rs Outdated Show resolved Hide resolved
test/sys/test_prctl.rs Show resolved Hide resolved
@SteveLauC
Copy link
Member

BTW, I guess some commits in QEMU can change some syscalls' behavior, that brings some weird test results... -> #2418

#2418 happens without a QEMU bump, we encountered it when upgrading the Linux CI base image from Ubuntu 20.04 to 22.04🤔

@Fearyncess Fearyncess force-pushed the add-la64-ci branch 2 times, most recently from 76f001a to 57e2a55 Compare September 22, 2024 06:24
@Fearyncess
Copy link
Contributor Author

Please also add this target to the target support list of Nix as a tier2 target.

Added.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding it!

@SteveLauC SteveLauC added this pull request to the merge queue Sep 22, 2024
Merged via the queue into nix-rust:master with commit a1384d0 Sep 22, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants