Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci.yml to add support for loongarch64 #2461

Closed
wants to merge 9 commits into from
Closed

Update ci.yml to add support for loongarch64 #2461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7140a79
Update ci.yml
donmor Jul 21, 2024
cfce184
Update README.md
donmor Jul 21, 2024
9073361
Update ci.yml
donmor Jul 21, 2024
147a606
Update ci.yml
donmor Jul 21, 2024
ecac51b
Update ci.yml
donmor Jul 21, 2024
a387131
Update ci.yml
donmor Jul 21, 2024
c245564
Update Cross.toml
donmor Jul 21, 2024
20f8cb1
Update Cross.toml
donmor Jul 21, 2024
b0730c3
Update Cross.toml
SteveLauC Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
contents: read

env:
MSRV: 1.69.0
MSRV: 1.71.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change the MSRV for an architecture, I think we should add a step that will overwrite the MSRV environment variable to 1.71.0 when ${{ matrix.target }} is loongarch64-unknown-linux-gnu, something like:

- name: change Rust toolchain version for Loongarch
  run: echo "MSRV=$(if [ '${{ matrix.target }}' = 'loongarch64-unknown-linux-gnu' ]; then echo '1.71.0'; else echo '${{ env.MSRV }}'; fi)" >> $GITHUB_ENV

RUSTFLAGS: -Dwarnings

jobs:
Expand Down Expand Up @@ -92,6 +92,7 @@ jobs:
mips64el-unknown-linux-gnuabi64,
mipsel-unknown-linux-gnu,
powerpc64le-unknown-linux-gnu,
loongarch64-unknown-linux-gnu,
]

steps:
Expand Down
3 changes: 3 additions & 0 deletions Cross.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ passthrough = [
"RUSTFLAGS",
"RUST_TEST_THREADS"
]
[target.loongarch64-unknown-linux-gnu]
image.name = "ghcr.io/loongarchlinux/archlinux:latest"
image.toolchain = ["loongarch64-unknown-linux-gnu"]
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ The following targets are supported by `nix`:
<li>x86_64-linux-android</li>
<li>x86_64-unknown-illumos</li>
<li>x86_64-unknown-netbsd</li>
<li>loongarch64-unknown-linux-gnu</li>
</td>
<td>
<li>armv7-unknown-linux-uclibceabihf</li>
Expand Down
Loading