Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom contract types via plugin config #239

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Add custom contract types via plugin config #239

merged 9 commits into from
Jan 12, 2024

Conversation

qduk
Copy link
Contributor

@qduk qduk commented Oct 18, 2023

This adds the ability to provide a list of contract types in your plugin configuration for use in the plugin. This is related to issue #103. I have a similar use case in my current work where Hardware and Software aren't specific enough and the use of a services and/or software maintenance are needed. Let me know what you guys think! Thanks!

@qduk qduk linked an issue Oct 18, 2023 that may be closed by this pull request
Request for new contract types: services (support/maintenance/project) and lease (circuits) #103
Closed
@qduk qduk mentioned this pull request Oct 20, 2023
Closed
@progala progala added status: internal review Internal discussion is required to move forward with issue type: enhancement Enhancement to existing functionality of the application labels Oct 30, 2023
@progala
Copy link
Contributor

progala commented Oct 30, 2023

Thanks @qduk, I like this idea. I'll have a look at this today and we should merge soon.

@progala progala self-assigned this Oct 30, 2023
@progala
Copy link
Contributor

progala commented Oct 30, 2023

@qduk I noticed that these new contract types don't show up in the filter drop down menu.

@qduk
Copy link
Contributor Author

qduk commented Oct 30, 2023

@progala hm let me look into it tomorrow and update here.

bradh11
bradh11 requested changes Oct 31, 2023
View reviewed changes
development/nautobot_config.py Outdated Show resolved Hide resolved
docs/admin/install.md Outdated Show resolved Hide resolved
nautobot_device_lifecycle_mgmt/utils.py Outdated Show resolved Hide resolved
nautobot_device_lifecycle_mgmt/utils.py Outdated Show resolved Hide resolved
@qduk qduk force-pushed the ab_contract_type branch from 3887e1e to cd01127 Compare October 31, 2023 14:59
@qduk
Copy link
Contributor Author

qduk commented Oct 31, 2023

@progala Can you give it another shot? I was able to see the contract types in the dropdown.
Screenshot 2023-10-31 at 10 35 00 AM

@qduk
Copy link
Contributor Author

qduk commented Oct 31, 2023

@bradh11 Thanks for the suggestions. Do I need to open this toward a different branch? I saw the other one was closed.

@progala
Copy link
Contributor

progala commented Nov 2, 2023

@bradh11 Thanks for the suggestions. Do I need to open this toward a different branch? I saw the other one was closed.

The other PR was closed as it was targeting develop. We tried to retarget it for ltm1.6 but diff was showing too many unrelated changes. Can you try branching off ltm1.6 and reapplying your changes?

@qduk qduk mentioned this pull request Nov 2, 2023
Closed
progala
progala requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion. Could you please also add tests for add_custom_contract_types

nautobot_device_lifecycle_mgmt/utils.py Outdated Show resolved Hide resolved
development/nautobot_config.py Outdated Show resolved Hide resolved
@qduk
Copy link
Contributor Author

qduk commented Jan 11, 2024

@progala Test added here as well. Let me know if these suffice. Thanks!

progala
progala approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @qduk !

@bradh11 bradh11 merged commit 796c411 into develop Jan 12, 2024
14 checks passed
@bradh11 bradh11 deleted the ab_contract_type branch January 12, 2024 16:35
@bradh11 bradh11 restored the ab_contract_type branch January 12, 2024 17:15
@bradh11 bradh11 mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progala progala progala approved these changes

@bradh11 bradh11 bradh11 approved these changes

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees

@progala progala

Labels
status: internal review Internal discussion is required to move forward with issue type: enhancement Enhancement to existing functionality of the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for new contract types: services (support/maintenance/project) and lease (circuits)
3 participants
@qduk @progala @bradh11