Add additional contract type to ltm_1.6 #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qduk - Thank for the updates and resubmitting this PR. Looks much better now against the ltm1.6 branch. |
|
@qduk Having a second look at this I think it could be worthwile to load additional contract types from environment, see my suggestion. Could you please add tests for |
progala
requested changes
Jan 9, 2024
Co-authored-by: Przemek Rogala <[email protected]>
Co-authored-by: Przemek Rogala <[email protected]>
|
@progala Test have been added and your suggestions committed! Let me know if those test do not suffice. |
|
@progala Do we want to go ahead and close one due to the discussion you had with John? Sounds like we will need to rethink the approach on this so it propagates everywhere a new contract type would be needed. |
|
Closed as agreed. New approach is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the same feature as #239 but with respect to the ltm_1.6 branch. The table in the docs was using config items from Golden Config so I changed the table to match the plugin.